linux-kernel - Re: [PATCH] objtool: fix libopcodes linking with static libraries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121192531.GN166857@noisy.programming.kicks-ass.net>
Date: Wed, 21 Jan 2026 20:25:31 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Sasha Levin <sashal@...nel.org>, acme@...nel.org, irogers@...gle.com,
	jpoimboe@...nel.org, linux-kernel@...r.kernel.org,
	regressions@...ts.linux.dev, torvalds@...ux-foundation.org,
	x86@...nel.org
Subject: Re: [PATCH] objtool: fix libopcodes linking with static libraries

On Wed, Jan 21, 2026 at 08:08:51PM +0100, Rafael J. Wysocki wrote:
> On Wed, Jan 21, 2026 at 5:25 PM Sasha Levin <sashal@...nel.org> wrote:
> >
> > Commit 436326bc525d ("objtool: fix build failure due to missing libopcodes
> > check") tests for libopcodes using an empty main(), which passes even when
> > static libraries lack their dependencies. This causes undefined reference
> > errors (xmalloc, bfd_get_bits, etc.) when linking against static libopcodes
> > without its required libbfd and libiberty.
> >
> > Fix by testing with an actual libopcodes symbol and trying increasingly
> > complete library combinations until one succeeds.
> >
> > Fixes: 436326bc525d ("objtool: fix build failure due to missing libopcodes check")
> > Reported-by: Rafael J. Wysocki <rafael@...nel.org>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> > ---
> >
> > Rafael, I'd appreciate if you could test this patch without the .so symlink
> > workaround. Thanks :)
> 
> Works here, so
> 
> Tested-by: Rafael J. Wysocki (Intel) <rafael@...nel.org>

Excellent, thanks all!