linux-kernel - Re: [PATCH v4 3/3] usb: dwc3: Log dwc3 address in traces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121001015.62ue4o75ntzmt7yr@synopsys.com>
Date: Wed, 21 Jan 2026 00:10:21 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Prashanth K <prashanth.k@....qualcomm.com>
CC: Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 3/3] usb: dwc3: Log dwc3 address in traces

On Mon, Jan 19, 2026, Prashanth K wrote:
> On 1/16/2026 11:21 PM, Thinh Nguyen wrote:
> > diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
> > index b6ba984bafcd..8e5d474fd54a 100644
> > --- a/drivers/usb/dwc3/trace.h
> > +++ b/drivers/usb/dwc3/trace.h
> > @@ -37,19 +37,22 @@ DEFINE_EVENT(dwc3_log_set_prtcap, dwc3_set_prtcap,
> >  );
> >  
> >  DECLARE_EVENT_CLASS(dwc3_log_io,
> > -	TP_PROTO(void *base, u32 offset, u32 value),
> > -	TP_ARGS(base, offset, value),
> > +	TP_PROTO(struct dwc3 *dwc, void *base, u31 offset, u32 value),
> > +	TP_ARGS(dwc, base, offset, value),
> >  	TP_STRUCT__entry(
> > +		__field(phy_addr_t, base_address)
> 
> Shouldn't we be using 'resource_size_t' instead ? Anyways its just
> typedef of 'phys_addr_t'.
> 

It seems more fitting to use phys_addr_t here for printing the address.
I'd use resource_size_t when calculating for the resource size. Let me
know if there's an issue.

BR,
Thinh