linux-kernel - Re: [PATCH -next v3 0/3] rcu/nocb: Cleanup patches for next merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f568bee5-9cda-40bb-977a-a9063bd2c611@paulmck-laptop>
Date: Wed, 21 Jan 2026 11:09:13 -0800
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Joel Fernandes <joelagnelf@...dia.com>
Cc: linux-kernel@...r.kernel.org, Boqun Feng <boqun.feng@...il.com>,
	rcu@...r.kernel.org, Frederic Weisbecker <frederic@...nel.org>,
	Neeraj Upadhyay <neeraj.upadhyay@...nel.org>,
	Josh Triplett <josh@...htriplett.org>,
	Uladzislau Rezki <urezki@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Zqiang <qiang.zhang@...ux.dev>
Subject: Re: [PATCH -next v3 0/3] rcu/nocb: Cleanup patches for next merge
 window

On Mon, Jan 19, 2026 at 06:12:20PM -0500, Joel Fernandes wrote:
> These are a few nocb related cleanup patches for the next merge window.
> 
> Also Frederic please object to the second patch ("Remove dead callback overload
> handling") if you would like, but I think based on our discussion I have
> implemented your suggestion, so it should be good.
> 
> Changes from v2:
> - Dropped patch 2 "Add warning if no rcuog wake up attempt happened during
>   overload" as it was not needed since we removed the dead CB overload handling.
> - Replaced "Add warning to detect if overload advancement is ever useful" with
>   "Remove dead callback overload handling" per Frederic's feedback - instead of
>   adding a warning, just remove the dead code path entirely.
> 
> nocb rcutorture scenarios passed overnight testing on my system.

I reverted three of your earlier patches in order to apply this, only
one of which I am really confident in.  Please check my -rcu tree to see
if any of the three should be added back in, and I am starting tests in
the meantime.

							Thanx, Paul

> Link to v2: https://lore.kernel.org/all/20260114173154.1701056-1-joelagnelf@nvidia.com/
> Link to v1: https://lore.kernel.org/all/20260101163417.1065705-1-joelagnelf@nvidia.com/
> 
> Joel Fernandes (3):
>   rcu/nocb: Remove unnecessary WakeOvfIsDeferred wake path
>   rcu/nocb: Remove dead callback overload handling
>   rcu/nocb: Extract nocb_defer_wakeup_cancel() helper
> 
>  kernel/rcu/tree.c      |  2 +-
>  kernel/rcu/tree.h      |  3 +-
>  kernel/rcu/tree_nocb.h | 80 ++++++++++++++----------------------------
>  3 files changed, 29 insertions(+), 56 deletions(-)
> 
> -- 
> 2.34.1
>