| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202601211015.DidNlKfG-lkp@intel.com>
Date: Wed, 21 Jan 2026 10:39:24 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-pci@...r.kernel.org, linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Bjorn Helgaas <helgaas@...nel.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v1 1/1] ACPI: PCI: simplify code with
acpi_get_local_u64_address()
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v6.19-rc6 next-20260120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ACPI-PCI-simplify-code-with-acpi_get_local_u64_address/20260121-004826
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20260120154015.1764021-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] ACPI: PCI: simplify code with acpi_get_local_u64_address()
config: i386-buildonly-randconfig-001-20260121
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build):
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601211015.DidNlKfG-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/acpi/pci_slot.c:44:6: warning: unused variable 'device' [-Wunused-variable]
44 | int device = -1;
| ^~~~~~
>> drivers/acpi/pci_slot.c:57:9: error: use of undeclared label 'out'
57 | goto out;
| ^
>> drivers/acpi/pci_slot.c:67:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
67 | status = acpi_evaluate_integer(handle, "_SUN", NULL, sun);
| ^
| int
>> drivers/acpi/pci_slot.c:67:33: error: use of undeclared identifier 'handle'
67 | status = acpi_evaluate_integer(handle, "_SUN", NULL, sun);
| ^
>> drivers/acpi/pci_slot.c:67:55: error: use of undeclared identifier 'sun'
67 | status = acpi_evaluate_integer(handle, "_SUN", NULL, sun);
| ^
>> drivers/acpi/pci_slot.c:68:2: error: expected identifier or '('
68 | if (ACPI_FAILURE(status)) {
| ^
drivers/acpi/pci_slot.c:74:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
74 | device = (adr >> 16) & 0xffff;
| ^
| int
>> drivers/acpi/pci_slot.c:74:12: error: use of undeclared identifier 'adr'
74 | device = (adr >> 16) & 0xffff;
| ^
drivers/acpi/pci_slot.c:75:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
75 | out:
| ^
| int
>> drivers/acpi/pci_slot.c:75:4: error: expected ';' after top level declarator
75 | out:
| ^
| ;
>> drivers/acpi/pci_slot.c:76:8: error: unknown type name 'buffer'
76 | kfree(buffer.pointer);
| ^
>> drivers/acpi/pci_slot.c:76:14: error: expected ')'
76 | kfree(buffer.pointer);
| ^
drivers/acpi/pci_slot.c:76:7: note: to match this '('
76 | kfree(buffer.pointer);
| ^
drivers/acpi/pci_slot.c:76:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
76 | kfree(buffer.pointer);
| ^
| int
drivers/acpi/pci_slot.c:77:2: error: expected identifier or '('
77 | return device;
| ^
>> drivers/acpi/pci_slot.c:78:1: error: extraneous closing brace ('}')
78 | }
| ^
1 warning and 14 errors generated.
vim +/out +57 drivers/acpi/pci_slot.c
8344b568f5bdc7 Alex Chiang 2008-06-10 40
8344b568f5bdc7 Alex Chiang 2008-06-10 41 static int
27663c5855b10a Matthew Wilcox 2008-10-10 42 check_slot(acpi_handle handle, unsigned long long *sun)
8344b568f5bdc7 Alex Chiang 2008-06-10 43 {
362b7077a5546b Matthew Wilcox 2008-07-22 44 int device = -1;
6705d4a3a5ffa1 Andy Shevchenko 2026-01-20 45 unsigned long long sta;
8344b568f5bdc7 Alex Chiang 2008-06-10 46 acpi_status status;
6705d4a3a5ffa1 Andy Shevchenko 2026-01-20 47 u64 adr;
8344b568f5bdc7 Alex Chiang 2008-06-10 48 struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
8344b568f5bdc7 Alex Chiang 2008-06-10 49
8344b568f5bdc7 Alex Chiang 2008-06-10 50 acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
409ffed2b6ae1d Joe Perches 2016-05-27 51 pr_debug("Checking slot on path: %s\n", (char *)buffer.pointer);
8344b568f5bdc7 Alex Chiang 2008-06-10 52
8344b568f5bdc7 Alex Chiang 2008-06-10 53 if (check_sta_before_sun) {
8344b568f5bdc7 Alex Chiang 2008-06-10 54 /* If SxFy doesn't have _STA, we just assume it's there */
8344b568f5bdc7 Alex Chiang 2008-06-10 55 status = acpi_evaluate_integer(handle, "_STA", NULL, &sta);
362b7077a5546b Matthew Wilcox 2008-07-22 56 if (ACPI_SUCCESS(status) && !(sta & ACPI_STA_DEVICE_PRESENT))
8344b568f5bdc7 Alex Chiang 2008-06-10 @57 goto out;
8344b568f5bdc7 Alex Chiang 2008-06-10 58 }
8344b568f5bdc7 Alex Chiang 2008-06-10 59
6705d4a3a5ffa1 Andy Shevchenko 2026-01-20 60 if (acpi_get_local_u64_address(handle, &adr))
6705d4a3a5ffa1 Andy Shevchenko 2026-01-20 61 pr_debug("_ADR returned with failure on %s\n",
6705d4a3a5ffa1 Andy Shevchenko 2026-01-20 62 (char *)buffer.pointer);
8344b568f5bdc7 Alex Chiang 2008-06-10 63 goto out;
8344b568f5bdc7 Alex Chiang 2008-06-10 64 }
8344b568f5bdc7 Alex Chiang 2008-06-10 65
8344b568f5bdc7 Alex Chiang 2008-06-10 66 /* No _SUN == not a slot == bail */
8344b568f5bdc7 Alex Chiang 2008-06-10 @67 status = acpi_evaluate_integer(handle, "_SUN", NULL, sun);
8344b568f5bdc7 Alex Chiang 2008-06-10 @68 if (ACPI_FAILURE(status)) {
409ffed2b6ae1d Joe Perches 2016-05-27 69 pr_debug("_SUN returned %d on %s\n",
409ffed2b6ae1d Joe Perches 2016-05-27 70 status, (char *)buffer.pointer);
8344b568f5bdc7 Alex Chiang 2008-06-10 71 goto out;
8344b568f5bdc7 Alex Chiang 2008-06-10 72 }
8344b568f5bdc7 Alex Chiang 2008-06-10 73
362b7077a5546b Matthew Wilcox 2008-07-22 @74 device = (adr >> 16) & 0xffff;
8344b568f5bdc7 Alex Chiang 2008-06-10 @75 out:
8344b568f5bdc7 Alex Chiang 2008-06-10 @76 kfree(buffer.pointer);
362b7077a5546b Matthew Wilcox 2008-07-22 77 return device;
8344b568f5bdc7 Alex Chiang 2008-06-10 @78 }
8344b568f5bdc7 Alex Chiang 2008-06-10 79
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
View attachment "reproduce" of type "text/plain" (710 bytes)
View attachment "config" of type "text/plain" (253818 bytes)
Powered by blists - more mailing lists