linux-kernel - Re: [RFC][PATCH 1/4] compiler-context-analysys: Add __cond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <515968cb-ce32-48df-b6da-794b4a80c0a4@acm.org>
Date: Wed, 21 Jan 2026 13:02:54 -0800
From: Bart Van Assche <bvanassche@....org>
To: Peter Zijlstra <peterz@...radead.org>, Marco Elver <elver@...gle.com>
Cc: linux-kernel@...r.kernel.org, bigeasy@...utronix.de, mingo@...nel.org,
 tglx@...utronix.de, will@...nel.org, boqun.feng@...il.com,
 longman@...hat.com, hch@....de, rostedt@...dmis.org, llvm@...ts.linux.dev
Subject: Re: [RFC][PATCH 1/4] compiler-context-analysys: Add __cond_releases()

On 1/21/26 11:02 AM, Peter Zijlstra wrote:
> Right, this was an on-demand thing. Lets add it when it becomes needed.

Please take a look at vma_start_read() in mm/mmap_lock.c. I think that
it needs a __cond_shared_release() annotation. From the documentation
block above that function:

  * IMPORTANT: RCU lock must be held upon entering the function, but 
upon error
  *            IT IS RELEASED. The caller must handle this correctly.

Thanks,

Bart.