linux-kernel - Re: [PATCH v2 1/1] ACPI: PCI: simplify code with acpi_get_local_u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260121231520.GA1221379@bhelgaas>
Date: Wed, 21 Jan 2026 17:15:20 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-pci@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v2 1/1] ACPI: PCI: simplify code with
 acpi_get_local_u64_address()

On Wed, Jan 21, 2026 at 09:50:49AM +0100, Andy Shevchenko wrote:
> Now we have a helper so there's no need to open-code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Bjorn Helgaas <bhelgaas@...gle.com>

Looks like most drivers/acpi commits capitalize the subject line,
e.g., s/simplify/Simplify/

> ---
> 
> v2: fixed a typo (LKP)
> 
>  drivers/acpi/pci_slot.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
> index 741bcc9d6d6a..15234b65ea22 100644
> --- a/drivers/acpi/pci_slot.c
> +++ b/drivers/acpi/pci_slot.c
> @@ -42,8 +42,9 @@ static int
>  check_slot(acpi_handle handle, unsigned long long *sun)
>  {
>  	int device = -1;
> -	unsigned long long adr, sta;
> +	unsigned long long sta;
>  	acpi_status status;
> +	u64 adr;
>  	struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
>  
>  	acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
> @@ -56,10 +57,9 @@ check_slot(acpi_handle handle, unsigned long long *sun)
>  			goto out;
>  	}
>  
> -	status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
> -	if (ACPI_FAILURE(status)) {
> -		pr_debug("_ADR returned %d on %s\n",
> -			 status, (char *)buffer.pointer);
> +	if (acpi_get_local_u64_address(handle, &adr)) {
> +		pr_debug("_ADR returned with failure on %s\n",
> +			 (char *)buffer.pointer);
>  		goto out;
>  	}
>  
> -- 
> 2.50.1
>