linux-kernel - [PATCH 2/2] Input: ili210x - convert to disable_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121232522.154771-2-marek.vasut+renesas@mailbox.org>
Date: Thu, 22 Jan 2026 00:23:48 +0100
From: Marek Vasut <marek.vasut+renesas@...lbox.org>
To: linux-input@...r.kernel.org
Cc: Marek Vasut <marek.vasut+renesas@...lbox.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	Cheng-Yang Chou <yphbchou0911@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Frank Li <Frank.Li@....com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Jinjie Ruan <ruanjinjie@...wei.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>,
	Marc Zyngier <maz@...nel.org>,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Thomas Gleixner <tglx@...nel.org>,
	linux-kernel@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org
Subject: [PATCH 2/2] Input: ili210x - convert to disable_valid_irq scoped guard

Use disable_valid_irq scoped guard to simplify the code and
deduplicate the polling and IRQ driver case. No functional
change.

Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>
---
Cc: "Peter Zijlstra (Intel)" <peterz@...radead.org>
Cc: Cheng-Yang Chou <yphbchou0911@...il.com>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Frank Li <Frank.Li@....com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: Marc Zyngier <maz@...nel.org>
Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Thomas Gleixner <tglx@...nel.org>
Cc: linux-input@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Cc: linux-renesas-soc@...r.kernel.org
---
 drivers/input/touchscreen/ili210x.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
index 3bf524a6ee204..70abbd675bb01 100644
--- a/drivers/input/touchscreen/ili210x.c
+++ b/drivers/input/touchscreen/ili210x.c
@@ -893,10 +893,7 @@ static ssize_t ili210x_firmware_update_store(struct device *dev,
 	 * the touch controller to disable the IRQs during update, so we have
 	 * to do it this way here.
 	 */
-	if (client->irq > 0) {
-		guard(disable_irq)(&client->irq);
-		error = ili210x_firmware_update(dev, fwbuf, ac_end, df_end);
-	} else {
+	scoped_guard(disable_valid_irq, &client->irq) {
 		error = ili210x_firmware_update(dev, fwbuf, ac_end, df_end);
 	}
 
-- 
2.51.0