linux-kernel - Re: [PATCH v3 5/8] lib/string_kunit: extend benchmarks to strnlen and chr searches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb396548-1a16-400d-bd88-91f54559fa4d@kylinos.cn>
Date: Wed, 21 Jan 2026 13:48:13 +0800
From: Feng Jiang <jiangfeng@...inos.cn>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: pjw@...nel.org, palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
 akpm@...ux-foundation.org, kees@...nel.org, andy@...nel.org,
 ebiggers@...nel.org, martin.petersen@...cle.com, ardb@...nel.org,
 charlie@...osinc.com, conor.dooley@...rochip.com, ajones@...tanamicro.com,
 linus.walleij@...aro.org, nathan@...nel.org,
 linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, Joel Stanley <joel@....id.au>
Subject: Re: [PATCH v3 5/8] lib/string_kunit: extend benchmarks to strnlen and
 chr searches

On 2026/1/20 15:48, Andy Shevchenko wrote:
> On Tue, Jan 20, 2026 at 02:58:49PM +0800, Feng Jiang wrote:
>> Extend the string benchmarking suite to include strnlen(), strchr(),
>> and strrchr().
>>
>> For character search functions (strchr and strrchr), the benchmark
> 
> strchr() and strrchr()

Will fix.

>> targets the null terminator. This ensures the entire string is scanned,
> 
> NUL character
> 
> (Also check terminology everywhere: NULL — is for NULL pointers, NUL is for
>  '\0' characters.)
> 

Thanks for the correction, I'll fix this and check other places as well.

>> providing a consistent measure of full-length processing efficiency
>> comparable to strlen().
> 
> Acked-by: Andy Shevchenko <andy@...nel.org>
> 

-- 
With Best Regards,
Feng Jiang