linux-kernel - Re: [PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXBvY_MjV2GZ0WPN@casper.infradead.org>
Date: Wed, 21 Jan 2026 06:17:07 +0000
From: Matthew Wilcox <willy@...radead.org>
To: zenghongling <zenghongling@...inos.cn>
Cc: muchun.song@...ux.dev, osalvador@...e.de, david@...nel.org,
	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, zhongling0719@....com
Subject: Re: [PATCH] mm/hugetlb_vmemmap: Use max() macro to simplify the code

On Wed, Jan 21, 2026 at 09:51:14AM +0800, zenghongling wrote:
> Use the max() macro to simplify the function and improve
> its readability.

How does this improve readability?  I understand what this does in
the ternary form.  I have to think far harder about it in the max()
form.

>  	if (!is_power_of_2(sizeof(struct page)))
>  		return 0;
> -	return size > 0 ? size : 0;
> +	return max(size, 0);
>  }