linux-kernel - Re: [PATCH v6 08/11] PCI: dwc: Invoke post_init in dw_pcie_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbnnvvpki6oaqaribiuycpshk7qmisl42x3iti24aqzzrw2rfr@afoer4ku4do4>
Date: Wed, 21 Jan 2026 13:12:16 +0530
From: "mani@...nel.org" <mani@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Hongxing Zhu <hongxing.zhu@....com>, Frank Li <frank.li@....com>, 
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>, "lpieralisi@...nel.org" <lpieralisi@...nel.org>, 
	"kwilczynski@...nel.org" <kwilczynski@...nel.org>, "robh@...nel.org" <robh@...nel.org>, 
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, 
	"bhelgaas@...gle.com" <bhelgaas@...gle.com>, "shawnguo@...nel.org" <shawnguo@...nel.org>, 
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, 
	"festevam@...il.com" <festevam@...il.com>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 08/11] PCI: dwc: Invoke post_init in
 dw_pcie_resume_noirq()

On Tue, Jan 20, 2026 at 04:04:41PM -0600, Bjorn Helgaas wrote:
> On Fri, Jan 09, 2026 at 09:27:50AM -0600, Bjorn Helgaas wrote:
> > ...
> 
> > The current commit log for this patch is this:
> > 
> >   Some SoCs like i.MX95 require enabling REFCLK after resuming from suspend
> >   in their post_init callback. So invoke the callback at the end of
> >   dw_pcie_resume_noirq() if available.
> > 
> > When .post_init() is called, the link is already up and PCIe devices
> > have already been enumerated.  I think REFCLK is required for the link
> > to come up, so it doesn't sound right to me that .post_init() would be
> > *enabling* REFCLK.
> 
> This never got resolved.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc-imx6&id=199c18221622
> says imx_pcie_host_post_init() enables REFCLK by applying the
> IMX_PCIE_FLAG_8GT_ECN_ERR051586 workaround.
> 
> I don't think that commit log is correct.  Can you please supply some
> correct text for that commit?
> 

Sorry, I messed it up. This callback is not supposed to enable REFCLK, but just
clear CLKREQ# override to allow the endpoint to drive it low when required.

I've just updated the commit text in the controller/dwc-imx6 branch.

- Mani

-- 
மணிவண்ணன் சதாசிவம்