linux-kernel - Re: [PATCH v4 4/5] PCI: dwc: Rework the error print of dw_pcie_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXCNHnuvXJJZPU3y@ryzen>
Date: Wed, 21 Jan 2026 09:23:58 +0100
From: Niklas Cassel <cassel@...nel.org>
To: manivannan.sadhasivam@....qualcomm.com
Cc: Jingoo Han <jingoohan1@...il.com>,
	Manivannan Sadhasivam <mani@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kwilczynski@...nel.org>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	vincent.guittot@...aro.org, zhangsenchuan@...incomputing.com,
	Shawn Lin <shawn.lin@...k-chips.com>,
	Richard Zhu <hongxing.zhu@....com>
Subject: Re: [PATCH v4 4/5] PCI: dwc: Rework the error print of
 dw_pcie_wait_for_link()

On Tue, Jan 20, 2026 at 11:17:43PM +0530, Manivannan Sadhasivam via B4 Relay wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
> 
> If the link fails to come up even after detecting the device on the bus
> i.e., if the LTSSM is not in Detect.Quiet and Detect.Active states, then
> dw_pcie_wait_for_link() should log it as an error.

Nit: maybe you should mention Poll.Active and Poll.Compliance here too?


> 
> So promote dev_info() to dev_err(), reword the error log to make it clear
> and also print the LTSSM state to aid debugging.
> 
> Tested-by: Richard Zhu <hongxing.zhu@....com>
> Tested-by: Vincent Guittot <vincent.guittot@...aro.org>
> Reviewed-by: Shawn Lin <shawn.lin@...k-chips.com>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
> ---

Regardless:
Reviewed-by: Niklas Cassel <cassel@...nel.org>