linux-kernel - Re: [PATCH v3 11/12] i2c: qcom-geni: Store of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82db5424-8013-487d-90bb-82f133cbcbf2@oss.qualcomm.com>
Date: Wed, 21 Jan 2026 14:29:33 +0530
From: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
To: Praveen Talari <praveen.talari@....qualcomm.com>,
        Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Mukesh Kumar Savaliya <mukesh.savaliya@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, bryan.odonoghue@...aro.org,
        dmitry.baryshkov@....qualcomm.com, bjorn.andersson@....qualcomm.com
Cc: prasad.sodagudi@....qualcomm.com, quic_vtanuku@...cinc.com,
        aniket.randive@....qualcomm.com, chandana.chiluveru@....qualcomm.com
Subject: Re: [PATCH v3 11/12] i2c: qcom-geni: Store of_device_id data in
 driver private struct

Acked-by: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>

On 1/12/2026 4:17 PM, Praveen Talari wrote:
> To avoid repeatedly fetching and checking platform data across various
> functions, store the struct of_device_id data directly in the i2c
> private structure. This change enhances code maintainability and reduces
> redundancy.
> 
> Signed-off-by: Praveen Talari <praveen.talari@....qualcomm.com>
> ---
>  drivers/i2c/busses/i2c-qcom-geni.c | 32 ++++++++++++++++--------------
>  1 file changed, 17 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index b0a18e3d57d9..1c9356e13b97 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -77,6 +77,13 @@ enum geni_i2c_err_code {
>  #define XFER_TIMEOUT		HZ
>  #define RST_TIMEOUT		HZ
>  
> +struct geni_i2c_desc {
> +	bool has_core_clk;
> +	char *icc_ddr;
> +	bool no_dma_support;
> +	unsigned int tx_fifo_depth;
> +};
> +
>  #define QCOM_I2C_MIN_NUM_OF_MSGS_MULTI_DESC	2
>  
>  /**
> @@ -121,13 +128,7 @@ struct geni_i2c_dev {
>  	bool is_tx_multi_desc_xfer;
>  	u32 num_msgs;
>  	struct geni_i2c_gpi_multi_desc_xfer i2c_multi_desc_config;
> -};
> -
> -struct geni_i2c_desc {
> -	bool has_core_clk;
> -	char *icc_ddr;
> -	bool no_dma_support;
> -	unsigned int tx_fifo_depth;
> +	const struct geni_i2c_desc *dev_data;
>  };
>  
>  struct geni_i2c_err_log {
> @@ -978,7 +979,6 @@ static int setup_gpi_dma(struct geni_i2c_dev *gi2c)
>  
>  static int geni_i2c_init(struct geni_i2c_dev *gi2c)
>  {
> -	const struct geni_i2c_desc *desc = NULL;
>  	u32 proto, tx_depth;
>  	bool fifo_disable;
>  	int ret;
> @@ -1001,8 +1001,7 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c)
>  		goto err;
>  	}
>  
> -	desc = device_get_match_data(gi2c->se.dev);
> -	if (desc && desc->no_dma_support)
> +	if (gi2c->dev_data->no_dma_support)
>  		fifo_disable = false;
>  	else
>  		fifo_disable = readl_relaxed(gi2c->se.base + GENI_IF_DISABLE_RO) & FIFO_IF_DISABLE;
> @@ -1020,8 +1019,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c)
>  		tx_depth = geni_se_get_tx_fifo_depth(&gi2c->se);
>  
>  		/* I2C Master Hub Serial Elements doesn't have the HW_PARAM_0 register */
> -		if (!tx_depth && desc)
> -			tx_depth = desc->tx_fifo_depth;
> +		if (!tx_depth && gi2c->dev_data->has_core_clk)
> +			tx_depth = gi2c->dev_data->tx_fifo_depth;
>  
>  		if (!tx_depth) {
>  			ret = dev_err_probe(gi2c->se.dev, -EINVAL,
> @@ -1064,7 +1063,6 @@ static int geni_i2c_probe(struct platform_device *pdev)
>  	struct geni_i2c_dev *gi2c;
>  	int ret;
>  	struct device *dev = &pdev->dev;
> -	const struct geni_i2c_desc *desc = NULL;
>  
>  	gi2c = devm_kzalloc(dev, sizeof(*gi2c), GFP_KERNEL);
>  	if (!gi2c)
> @@ -1076,7 +1074,7 @@ static int geni_i2c_probe(struct platform_device *pdev)
>  	if (IS_ERR(gi2c->se.base))
>  		return PTR_ERR(gi2c->se.base);
>  
> -	desc = device_get_match_data(&pdev->dev);
> +	gi2c->dev_data = device_get_match_data(&pdev->dev);
>  
>  	ret = device_property_read_u32(dev, "clock-frequency",
>  				       &gi2c->clk_freq_out);
> @@ -1215,6 +1213,10 @@ static const struct dev_pm_ops geni_i2c_pm_ops = {
>  									NULL)
>  };
>  
> +static const struct geni_i2c_desc geni_i2c = {
> +	.icc_ddr = "qup-memory",
> +};
> +
>  static const struct geni_i2c_desc i2c_master_hub = {
>  	.has_core_clk = true,
>  	.icc_ddr = NULL,
> @@ -1223,7 +1225,7 @@ static const struct geni_i2c_desc i2c_master_hub = {
>  };
>  
>  static const struct of_device_id geni_i2c_dt_match[] = {
> -	{ .compatible = "qcom,geni-i2c" },
> +	{ .compatible = "qcom,geni-i2c", .data = &geni_i2c },
>  	{ .compatible = "qcom,geni-i2c-master-hub", .data = &i2c_master_hub },
>  	{}
>  };