linux-kernel - Re: [PATCH v2] x86/lib: Optimize num_digits() and fix INT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae73088a-b914-4bb1-8554-b16da1256079@formalgen.com>
Date: Wed, 21 Jan 2026 11:40:07 +0100
From: David Desobry <david.desobry@...malgen.com>
To: David Laight <david.laight.linux@...il.com>
Cc: "H. Peter Anvin" <hpa@...or.com>, tglx@...nel.org, mingo@...hat.com,
 bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] x86/lib: Optimize num_digits() and fix INT_MIN
 overflow

On 1/21/26 10:54, David Laight wrote:

>> I'm not familiar enough with the rest of the codebase to know if
>> changing the function signature to unsigned int is correct here.
> 
> In theory you'd need to change the name and all the callers.
> 
> 	David
> 
> 

Agreed. It turns out there were very few callers.

I have just submitted V5, which renames the function to 
num_digits_u32(), switches the interface to unsigned int, and updates 
all callers accordingly.

David