linux-kernel - Re: REGRESSION on linux-next (next-20260115)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d83c0d0-8f82-40a8-bca6-7052658a5fb6@intel.com>
Date: Wed, 21 Jan 2026 17:43:50 +0530
From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@...el.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC: <hansg@...nel.org>, "Kurmi, Suresh Kumar" <suresh.kumar.kurmi@...el.com>,
	"Saarinen, Jani" <jani.saarinen@...el.com>, "intel-gfx@...ts.freedesktop.org"
	<intel-gfx@...ts.freedesktop.org>, "intel-xe@...ts.freedesktop.org"
	<intel-xe@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<linux-rt-devel@...ts.linux.dev>, <sfr@...b.auug.org.au>,
	<ilpo.jarvinen@...ux.intel.com>, <regressions@...mhuis.info>
Subject: Re: REGRESSION on linux-next (next-20260115)



On 1/21/2026 2:31 PM, Sebastian Andrzej Siewior wrote:
> On 2026-01-21 13:59:38 [+0530], Borah, Chaitanya Kumar wrote:
>>
>> Looks like it.
>>    9:          1          0  IO-APIC   9-fasteoi   acpi, INT0002
> 
> Does the following help?
> 
> diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/x86/intel/int0002_vgpio.c
> index 6f5629dc3f8db..562e880256436 100644
> --- a/drivers/platform/x86/intel/int0002_vgpio.c
> +++ b/drivers/platform/x86/intel/int0002_vgpio.c
> @@ -206,8 +206,8 @@ static int int0002_probe(struct platform_device *pdev)
>   	 * FIXME: augment this if we managed to pull handling of shared
>   	 * IRQs into gpiolib.
>   	 */
> -	ret = devm_request_irq(dev, irq, int0002_irq,
> -			       IRQF_ONESHOT | IRQF_SHARED, "INT0002", chip);
> +	ret = devm_request_irq(dev, irq, int0002_irq, IRQF_SHARED, "INT0002",
> +			       chip);
>   	if (ret) {
>   		dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret);
>   		return ret;
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index 266f2b39213a0..b2bb878abd113 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -228,7 +228,7 @@ static inline int __must_check
>   devm_request_irq(struct device *dev, unsigned int irq, irq_handler_t handler,
>   		 unsigned long irqflags, const char *devname, void *dev_id)
>   {
> -	return devm_request_threaded_irq(dev, irq, handler, NULL, irqflags,
> +	return devm_request_threaded_irq(dev, irq, handler, NULL, irqflags | IRQF_COND_ONESHOT,
>   					 devname, dev_id);
>   }
>   
> My guess would be that the int0002_vgpio.c results in a warning without
> requesting the interrupt while the interrupt.h change should fix it and
> the warning should be gone.
> 

This helps. Thank you for the patch. Would you be floating it soon?

==
Chaitanya