linux-kernel - Re: [PATCH 4/4] gpu: tyr: remove redundant `.as_ref()` for `dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <26F297F3-A93C-4998-9522-CFAD15C9A701@collabora.com>
Date: Wed, 21 Jan 2026 09:25:29 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Gary Guo <gary@...yguo.net>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Danilo Krummrich <dakr@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org,
 dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 4/4] gpu: tyr: remove redundant `.as_ref()` for `dev_*`
 print

> On 20 Jan 2026, at 15:11, Gary Guo <gary@...nel.org> wrote:
> 
> From: Gary Guo <gary@...yguo.net>
> 
> This is now handled by the macro itself.
> 
> Signed-off-by: Gary Guo <gary@...yguo.net>
> ---
> drivers/gpu/drm/tyr/driver.rs | 2 +-
> drivers/gpu/drm/tyr/gpu.rs    | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs
> index 2a45d0288825..fe991d8cbb4a 100644
> --- a/drivers/gpu/drm/tyr/driver.rs
> +++ b/drivers/gpu/drm/tyr/driver.rs
> @@ -140,7 +140,7 @@ fn probe(
> 
>         // We need this to be dev_info!() because dev_dbg!() does not work at
>         // all in Rust for now, and we need to see whether probe succeeded.
> -        dev_info!(pdev.as_ref(), "Tyr initialized correctly.\n");
> +        dev_info!(pdev, "Tyr initialized correctly.\n");
>         Ok(driver)
>     }
> }
> diff --git a/drivers/gpu/drm/tyr/gpu.rs b/drivers/gpu/drm/tyr/gpu.rs
> index bfbf2a1d80e6..04a0a5d5ef3a 100644
> --- a/drivers/gpu/drm/tyr/gpu.rs
> +++ b/drivers/gpu/drm/tyr/gpu.rs
> @@ -98,7 +98,7 @@ pub(crate) fn log(&self, pdev: &platform::Device) {
>         };
> 
>         dev_info!(
> -            pdev.as_ref(),
> +            pdev,
>             "mali-{} id 0x{:x} major 0x{:x} minor 0x{:x} status 0x{:x}",
>             model_name,
>             self.gpu_id >> 16,
> @@ -108,7 +108,7 @@ pub(crate) fn log(&self, pdev: &platform::Device) {
>         );
> 
>         dev_info!(
> -            pdev.as_ref(),
> +            pdev,
>             "Features: L2:{:#x} Tiler:{:#x} Mem:{:#x} MMU:{:#x} AS:{:#x}",
>             self.l2_features,
>             self.tiler_features,
> @@ -118,7 +118,7 @@ pub(crate) fn log(&self, pdev: &platform::Device) {
>         );
> 
>         dev_info!(
> -            pdev.as_ref(),
> +            pdev,
>             "shader_present=0x{:016x} l2_present=0x{:016x} tiler_present=0x{:016x}",
>             self.shader_present,
>             self.l2_present,
> -- 
> 2.51.2
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>