linux-kernel - [PATCH v2] vmcoreinfo: make hwerr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260122-fix_vmcoreinfo-v2-1-2d6311f9e36c@debian.org>
Date: Thu, 22 Jan 2026 02:39:36 -0800
From: Breno Leitao <leitao@...ian.org>
To: akpm@...ux-foundation.org, bhe@...hat.com
Cc: vgoyal@...hat.com, dyoung@...hat.com, xueshuai@...ux.alibaba.com, 
 tony.luck@...el.com, linux-kernel@...r.kernel.org, osandov@...ndov.com, 
 kernel-team@...a.com, Breno Leitao <leitao@...ian.org>
Subject: [PATCH v2] vmcoreinfo: make hwerr_data visible for debugging

If the kernel is compiled with LTO, hwerr_data symbol might be lost, and
vmcoreinfo doesn't have it dumped. This is currently seen in some
production kernels with LTO enabled.

Remove the static qualifier from hwerr_data so that the information is
still preserved when the kernel is built with LTO. Making hwerr_data
a global symbol ensures its debug info survives the LTO link process and
appears in kallsyms. Also document it, so, it doesn't get removed in the
future as suggested by akpm.

Signed-off-by: Breno Leitao <leitao@...ian.org>
---
Changes in v2:
- Add a comment to explain why the array is global (akpm)
- Link to v1: https://patch.msgid.link/20260121-fix_vmcoreinfo-v1-1-39e96fab670e@debian.org
---
 kernel/vmcore_info.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/kernel/vmcore_info.c b/kernel/vmcore_info.c
index 22b3205dd4dc5..46198580373a4 100644
--- a/kernel/vmcore_info.c
+++ b/kernel/vmcore_info.c
@@ -36,7 +36,11 @@ struct hwerr_info {
 	time64_t timestamp;
 };
 
-static struct hwerr_info hwerr_data[HWERR_RECOV_MAX];
+/*
+ * The hwerr_data[] array is declared with global scope so that it remains
+ * accessible to vmcoreinfo even when Link Time Optimization (LTO) is enabled.
+ */
+struct hwerr_info hwerr_data[HWERR_RECOV_MAX];
 
 Elf_Word *append_elf_note(Elf_Word *buf, char *name, unsigned int type,
 			  void *data, size_t data_len)

---
base-commit: 053966c344dbd346e71305f530e91ea77916189f
change-id: 20260121-fix_vmcoreinfo-01592f705a77

Best regards,
--  
Breno Leitao <leitao@...ian.org>