linux-kernel - Re: [PATCH v5 1/6] i2c: designware: Optimize flag reading in i2c_dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXImLrvsLBExAX4f@zenone.zhora.eu>
Date: Thu, 22 Jan 2026 14:29:48 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Benoît Monin <benoit.monin@...tlin.com>
Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Clark Williams <clrkwllms@...nel.org>, 
	Steven Rostedt <rostedt@...dmis.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Gregory CLEMENT <gregory.clement@...tlin.com>, Théo Lebrun <theo.lebrun@...tlin.com>, 
	Tawfik Bayouk <tawfik.bayouk@...ileye.com>, Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
	Dmitry Guzman <dmitry.guzman@...ileye.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH v5 1/6] i2c: designware: Optimize flag reading in
 i2c_dw_read()

Hi Benoit,

On Tue, Jan 20, 2026 at 10:28:01AM +0100, Benoît Monin wrote:
> Optimize the i2c_dw_read() function by reading the message flags only
> once per message, rather than for every byte.
> 
> The message flags are accessed both in the outer loop and the inner loop,
> so move the declaration of the local flags variable to the outer loop.
> 
> The message index is only modified by the outer loop, so reading the
> flags in the inner loop was always getting the same value.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Benoît Monin <benoit.monin@...tlin.com>

This patch has already been applied. If you are going to respin,
please take it off.

Andi