linux-kernel - Re: [PATCH v5 3/6] i2c: designware: Add dedicated algorithm for AMD NAVI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXImglYjurMu-_7G@zenone.zhora.eu>
Date: Thu, 22 Jan 2026 14:31:30 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Benoît Monin <benoit.monin@...tlin.com>, 
	Mika Westerberg <mika.westerberg@...ux.intel.com>, Jan Dabros <jsd@...ihalf.com>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Clark Williams <clrkwllms@...nel.org>, 
	Steven Rostedt <rostedt@...dmis.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Gregory CLEMENT <gregory.clement@...tlin.com>, Théo Lebrun <theo.lebrun@...tlin.com>, 
	Tawfik Bayouk <tawfik.bayouk@...ileye.com>, Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, 
	Dmitry Guzman <dmitry.guzman@...ileye.com>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH v5 3/6] i2c: designware: Add dedicated algorithm for AMD
 NAVI

Hi Benoit,

On Tue, Jan 20, 2026 at 11:39:46AM +0200, Andy Shevchenko wrote:
> On Tue, Jan 20, 2026 at 10:28:03AM +0100, Benoît Monin wrote:
> > Apart from runtime PM, there is nothing in common between i2c_dw_xfer()
> > and amd_i2c_dw_xfer_quirk(), so give AMD NAVI controller its own algorithm
> > instead of calling the quirk from i2c_dw_xfer().
> > 
> > Add runtime PM handling to amd_i2c_dw_xfer_quirk() and a dedicated
> > i2c_algorithm for AMD NAVI controllers. The adapter algorithm is set
> > during probe based on the device model.
> > 
> > This way we avoid checking for the device model at the start of every
> > transfer.
> 
> ...
> 
> > +	ACQUIRE(pm_runtime_active_auto_try, pm)(dev->dev);
> > +	if (ACQUIRE_ERR(pm_runtime_active_auto_try, &pm))
> > +		return -ENXIO;
> 
> There are PM_ACQUIRE_*() macros available now.

I already applied this patch. You could eventually send a new one
using the PM_ACQUIRE_*() as suggested by Andy.

Thanks,
Andi