linux-kernel - Re: [PATCH v1] ACPI: PM: Adjust messages regarding postponed ACPI PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fzcmlu2iew2sc7dvooig43c6kkzk74rj5gkseenyvhjesakepu@qn2256b4i6zw>
Date: Wed, 21 Jan 2026 18:06:20 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Linux ACPI <linux-acpi@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v1] ACPI: PM: Adjust messages regarding postponed ACPI PM

On Tue, Jan 13, 2026 at 02:38:41PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The debug messages added by commit f7599be2bb76 ("ACPI: PM: postpone
> bringing devices to D0 unless we need them") in acpi_subsys_resume_early()
> and acpi_subsys_resume() are not quite accurate because what is postponed
> is not just a transition to D0, but also an adjustment of the device's
> wakeup setting (which may involve disabling a GPE among other things).
> Moreover, these messages don't even mention ACPI.
> 
> Rephrase them and adjust the style to match other messages in device_pm.c.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Makes sense to me.

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

> ---
>  drivers/acpi/device_pm.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -1251,7 +1251,7 @@ static int acpi_subsys_resume_early(stru
>  		return 0;
>  
>  	if (pm && !pm->resume_early) {
> -		dev_dbg(dev, "postponing D0 transition to normal resume stage\n");
> +		dev_dbg(dev, "Postponing ACPI PM to normal resume stage\n");
>  		return 0;
>  	}
>  
> @@ -1273,7 +1273,7 @@ static int acpi_subsys_resume(struct dev
>  	int ret = 0;
>  
>  	if (!dev_pm_skip_resume(dev) && pm && !pm->resume_early) {
> -		dev_dbg(dev, "executing postponed D0 transition\n");
> +		dev_dbg(dev, "Applying postponed ACPI PM\n");
>  		ret = acpi_dev_resume(dev);
>  	}
>  

Thanks.

-- 
Dmitry