linux-kernel - Re: [PATCH 05/26] rv/rvgen: remove unnecessary semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bjilso0b.fsf@yellow.woof>
Date: Thu, 22 Jan 2026 15:47:16 +0100
From: Nam Cao <namcao@...utronix.de>
To: Wander Lairson Costa <wander@...hat.com>, Steven Rostedt
 <rostedt@...dmis.org>, Gabriele Monaco <gmonaco@...hat.com>, Wander
 Lairson Costa <wander@...hat.com>, open list
 <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION (RV)"
 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/26] rv/rvgen: remove unnecessary semicolons

Wander Lairson Costa <wander@...hat.com> writes:
> Remove unnecessary semicolons from Python code in the rvgen tool.
> Python does not require semicolons to terminate statements, and
> their presence goes against PEP 8 style guidelines. These semicolons
> were likely added out of habit from C-style languages.
>
> The changes affect four instances across two files. In dot2c.py, one
> semicolon is removed from a boolean assignment. In dot2k.py, three
> semicolons are removed from string append operations that build
> generated C code. Note that the semicolons inside the string literals
> themselves are correctly preserved as they are part of the C code
> being generated, not Python syntax.
>
> This cleanup improves consistency with Python coding standards and
> aligns with the recent improvements to remove other Python
> anti-patterns from the codebase.
>
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>

Reviewed-by: Nam Cao <namcao@...utronix.de>