linux-kernel - Re: [PATCH] perf vendor events amd: Fix Zen 5 MAB allocation events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWH+GT-wuw5e-0MQQanUNMqUGVD+V=y7vq2jN4xe_GEmQ@mail.gmail.com>
Date: Thu, 22 Jan 2026 08:00:09 -0800
From: Ian Rogers <irogers@...gle.com>
To: Sandipan Das <sandipan.das@....com>
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, James Clark <james.clark@...aro.org>, 
	Suyash Mahar <smahar@...a.com>, Ravi Bangoria <ravi.bangoria@....com>, 
	Ananth Narayan <ananth.narayan@....com>
Subject: Re: [PATCH] perf vendor events amd: Fix Zen 5 MAB allocation events

On Thu, Jan 22, 2026 at 12:10 AM Sandipan Das <sandipan.das@....com> wrote:
>
> The unit masks for PMCx041 vary across different generations of Zen
> processors. Fix the Zen 5 events based on PMCx041 as they incorrectly
> use the same unit masks as that of Zen 4.
>
> Fixes: 45c072f2537a ("perf vendor events amd: Add Zen 5 core events")
> Reported-by: Suyash Mahar <smahar@...a.com>
> Signed-off-by: Sandipan Das <sandipan.das@....com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/pmu-events/arch/x86/amdzen5/load-store.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/x86/amdzen5/load-store.json b/tools/perf/pmu-events/arch/x86/amdzen5/load-store.json
> index ff6627a77805..06bbaea15925 100644
> --- a/tools/perf/pmu-events/arch/x86/amdzen5/load-store.json
> +++ b/tools/perf/pmu-events/arch/x86/amdzen5/load-store.json
> @@ -70,19 +70,19 @@
>      "EventName": "ls_mab_alloc.load_store_allocations",
>      "EventCode": "0x41",
>      "BriefDescription": "Miss Address Buffer (MAB) entries allocated by a Load-Store (LS) pipe for load-store allocations.",
> -    "UMask": "0x3f"
> +    "UMask": "0x07"
>    },
>    {
>      "EventName": "ls_mab_alloc.hardware_prefetcher_allocations",
>      "EventCode": "0x41",
>      "BriefDescription": "Miss Address Buffer (MAB) entries allocated by a Load-Store (LS) pipe for hardware prefetcher allocations.",
> -    "UMask": "0x40"
> +    "UMask": "0x08"
>    },
>    {
>      "EventName": "ls_mab_alloc.all_allocations",
>      "EventCode": "0x41",
>      "BriefDescription": "Miss Address Buffer (MAB) entries allocated by a Load-Store (LS) pipe for all types of allocations.",
> -    "UMask": "0x7f"
> +    "UMask": "0x0f"
>    },
>    {
>      "EventName": "ls_dmnd_fills_from_sys.local_l2",
> --
> 2.43.0
>