[<prev] [next>] [day] [month] [year] [list]
Message-ID: <D29814F7-69C2-4C64-AF05-87AE6019DE21@protonmail.com>
Date: Thu, 22 Jan 2026 15:37:23 +0000
From: Arturs Artamonovs <arturs.artamonovs@...tonmail.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: arturs.artamonovs@...log.com, Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>, Greg Malysa <greg.malysa@...esys.com>, Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Utsav Agarwal <Utsav.Agarwal@...log.com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, Thomas Gleixner <tglx@...utronix.de>, Andi Shyti <andi.shyti@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jirislaby@...nel.org>, Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>, soc@...nel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, linux-serial@...r.kernel.org, adsp-linux@...log.com, Nathan Barrett-Morrison
<nathan.morrison@...esys.com>
Subject: Re: [PATCH 00/21] Adding support of ADI ARMv8 ADSP-SC598 SoC.
Hi, big thanks to Krysztof, Arnd, Rob and Linus Walleij for the reviewing first set of patches that were sent some time ago. I have reviewed comments few times since then and Im currently at last stage of internal review for v2 series those are planned to be sent sometime in near future.
> On 16 Sep 2024, at 10:05, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 12/09/2024 20:24, Arturs Artamonovs via B4 Relay wrote:
>> This set of patches based on ADI fork of Linux Kerenl that support family of ADSP-SC5xx
>> SoC's and used by customers for some time . Patch series contains minimal set
>> of changes to add ADSP-SC598 support to upstream kernel. This series include
>> UART,I2C,IRQCHIP,RCU drivers and device-tree to be able boot on EV-SC598-SOM
>> board into serial shell and able to reset the board. Current SOM board
>> requires I2C expander to enable UART output.
>>
>> UART,I2C and PINCTRL drivers are based on old Blackfin drivers with
>> ADSP-SC5xx related bug fixes and improvments.
>>
>> Signed-off-by: Arturs Artamonovs <arturs.artamonovs@...log.com>
>> ---
>
> For new platform, be sure you have 0 warnings:
> 1. Please run standard kernel tools for static analysis, like
> coccinelle, smatch and sparse, and fix reported warnings.
>
> 2. Also check for warnings when building with W=1. Most of these
> commands (checks or W=1 build) can build specific targets, like some
> directory, to narrow the scope to only your code. The code here looks
> like it needs a fix. Feel free to get in touch if the warning is not clear.
>
> 3. Fix all compile test warning reported by LKP and check for common
> configs, regardless of reports.
>
> 4. Please run `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> 5. Please run scripts/checkpatch.pl and fix reported warnings. Then
> please run `scripts/checkpatch.pl --strict` and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run.
>
>
> Best regards,
> Krzysztof
>
>
Powered by blists - more mailing lists