linux-kernel - [PATCH] drm:dw-mipi-dsi: avoid invalidating config by removing dw_mipi_dsi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260122022803.6963-1-shu.sansan@163.com>
Date: Wed, 21 Jan 2026 18:28:03 -0800
From: shu.sansan@....com
To: andrzej.hajda@...el.com,
	neil.armstrong@...aro.org,
	rfoss@...nel.org
Cc: laurent.pinchart@...asonboard.com,
	jonas@...boo.se,
	jernej.skrabec@...il.com,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	tzimmermann@...e.de,
	airlied@...il.com,
	simona@...ll.ch,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	guofu wan <lizwan0412@...il.com>,
	guofu wan <shu.sansan@....com>
Subject: [PATCH] drm:dw-mipi-dsi: avoid invalidating config by removing dw_mipi_dsi_set_mode

From: guofu wan <lizwan0412@...il.com>

The dw_mipi_dsi_set_mode() function performs a DSI power-off operation via
dsi_write(dsi, DSI_PWR_UP, RESET), which invalidates all previously
applied configurations.

Since the original code already handles the command mode configuration
within dw_mipi_dsi_command_mode_config(), re-invoking the set_mode
function is redundant and counterproductive. Removing this call ensures
that the driver directly executes dsi_write(dsi, DSI_PWR_UP, POWERUP),
preserving the existing settings.

Signed-off-by: guofu wan <shu.sansan@....com>
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index 8fc2e282ff11..b02373f16bed 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -1015,8 +1015,7 @@ static void dw_mipi_dsi_mode_set(struct dw_mipi_dsi *dsi,
 
 	dw_mipi_dsi_wait_for_two_frames(adjusted_mode);
 
-	/* Switch to cmd mode for panel-bridge pre_enable & panel prepare */
-	dw_mipi_dsi_set_mode(dsi, 0);
+	dsi_write(dsi, DSI_PWR_UP, POWERUP);
 
 	if (phy_ops->power_on)
 		phy_ops->power_on(dsi->plat_data->priv_data);
-- 
2.17.1