linux-kernel - Re: [PATCH 19/26] rv/rvgen: add abstract method stubs to Container class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qdpirvf.fsf@yellow.woof>
Date: Thu, 22 Jan 2026 16:33:56 +0100
From: Nam Cao <namcao@...utronix.de>
To: Gabriele Monaco <gmonaco@...hat.com>, Wander Lairson Costa
 <wander@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, open list
 <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION
 (RV)" <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/26] rv/rvgen: add abstract method stubs to Container
 class

Gabriele Monaco <gmonaco@...hat.com> writes:
> On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote:
>> The Container class extends RVGenerator but was missing implementations
>> for several abstract methods decorated with @not_implemented in the base
>> class. This could lead to NotImplementedError exceptions if code paths
>> attempt to call these methods on Container instances.
>> 
>> Add empty-string returning stub implementations for
>> fill_tracepoint_handlers_skel,
>> fill_tracepoint_attach_probe, fill_tracepoint_detach_helper, and
>> fill_monitor_class_type. These empty returns are semantically correct
>> since Container is a grouping mechanism for organizing monitors, not an
>> actual monitor that generates tracepoint-specific C code.
>> 
>> Signed-off-by: Wander Lairson Costa <wander@...hat.com>
>> ---
>
> Just like the previous patch, the NotImplementedError here highlights a weakness
> in the design we should improve instead of cover.
> If all those fillers don't make sense for containers, we should instead move
> them to Monitor and leave RVGenerator alone.

Agree.

Nam