linux-kernel - Re: [PATCH 3/3] mm: memfd_luo: restore and free memfd_luo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bBRGo3fQJ9dYhGHzOZU9hhLX8Yc=BjLph9HG6zuk_vE5A@mail.gmail.com>
Date: Thu, 22 Jan 2026 13:03:50 -0500
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: Pratyush Yadav <pratyush@...nel.org>
Cc: Hugh Dickins <hughd@...gle.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Mike Rapoport <rppt@...nel.org>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] mm: memfd_luo: restore and free memfd_luo_ser on failure

> ---
>  mm/memfd_luo.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c
> index 01a72e4d3ef6..a34fccc23b6a 100644
> --- a/mm/memfd_luo.c
> +++ b/mm/memfd_luo.c
> @@ -447,7 +447,8 @@ static int memfd_luo_retrieve(struct liveupdate_file_op_args *args)
>         file = memfd_alloc_file("", 0);
>         if (IS_ERR(file)) {
>                 pr_err("failed to setup file: %pe\n", file);
> -               return PTR_ERR(file);
> +               err = PTR_ERR(file);
> +               goto free_ser;
>         }
>
>         vfs_setpos(file, ser->pos, MAX_LFS_FILESIZE);
> @@ -473,7 +474,8 @@ static int memfd_luo_retrieve(struct liveupdate_file_op_args *args)
>
>  put_file:
>         fput(file);
> -
> +free_ser:
> +       kho_restore_free(ser);

Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>