linux-kernel - Re: [PATCH] spi: dw-mmio: support suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0bd831a-08dd-4c2c-97e8-896f885cdbe8@sirena.org.uk>
Date: Thu, 22 Jan 2026 17:57:42 +0000
From: Mark Brown <broonie@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: dw-mmio: support suspend/resume

On Thu, Jan 22, 2026 at 11:50:46PM +0800, Jisheng Zhang wrote:

> +static int dw_spi_mmio_suspend(struct device *dev)
> +{

> +	clk_disable_unprepare(dwsmmio->pclk);
> +	clk_disable_unprepare(dwsmmio->clk);

These were allocated using devm_clk_get_prepare_enable() so we shouldn't
really be fiddling with the state at runtime.  In practice this should
always be fine I think but it's not really something we're supposed to
be doing, in theory we could fail to resume and then end up doing a
double disable on removal.  Probably the open coded version would have
the same issue though so perhaps this is pedantic...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)