linux-kernel - Re: [PATCH v6 4/5] iio: proximity: rfd77402: Document device private data structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHc1_P6cugsNNFW560BsM8CsFN=2iv_hU30fUAF3qZ1vZLTdXA@mail.gmail.com>
Date: Thu, 22 Jan 2026 23:12:12 +0530
From: Shrikant <raskar.shree97@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, skhan@...uxfoundation.org, david.hunter.linux@...il.com, 
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 4/5] iio: proximity: rfd77402: Document device private
 data structure

On Wed, Jan 21, 2026 at 2:48 PM Andy Shevchenko
<andriy.shevchenko@...el.com> wrote:
>
> On Wed, Jan 21, 2026 at 02:05:44AM +0530, Shrikant Raskar via B4 Relay wrote:
>
> > Add kernel-doc style comments for struct rfd77402_data to describe
> > the purpose of each member.
>
> Assuming checkpatch.pl doesn't complain (see below why),
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
>
> ...
>
> > +/**
> > + * struct rfd77402_data - device-specific data for the RFD77402 sensor
> > + * @client: I2C client handle
> > + * @lock: mutex to serialize sensor reads
> > + */
> >  struct rfd77402_data {
> >       struct i2c_client *client;
> > -     /* Serialize reads from the sensor */
>
> Not sure if this can be removed due to some checkpatch checks.
> Have you run it to verify?
Yes, I verified using checkpatch and it did not complain.

Regards,
Shrikant