linux-kernel - Re: kernel/liveupdate/kexec_handover.c:994 kho_preserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260122104238.54189a538153a0323453d61f@linux-foundation.org>
Date: Thu, 22 Jan 2026 10:42:38 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: Dan Carpenter <dan.carpenter@...aro.org>, oe-kbuild@...ts.linux.dev,
 lkp@...el.com, oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Linux Memory Management List <linux-mm@...ck.org>, Jason Gunthorpe
 <jgg@...dia.com>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>
Subject: Re: kernel/liveupdate/kexec_handover.c:994 kho_preserve_vmalloc()
 warn: missing error code 'err'

On Thu, 22 Jan 2026 13:14:49 -0500 Pasha Tatashin <pasha.tatashin@...een.com> wrote:

> > --- a/kernel/liveupdate/kexec_handover.c~a
> > +++ a/kernel/liveupdate/kexec_handover.c
> > @@ -1011,8 +1011,10 @@ int kho_preserve_vmalloc(void *ptr, stru
> >                 chunk->phys[idx++] = phys;
> >                 if (idx == ARRAY_SIZE(chunk->phys)) {
> >                         chunk = new_vmalloc_chunk(chunk);
> > -                       if (!chunk)
> > +                       if (!chunk) {
> > +                               err = -ENOMEM;
> >                                 goto err_free;
> > +                       }
> 
> Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>

Cool.  I think I'll turn this into a 6.19 hotfix - it is a slight bug
and we don't want people to keep telling us about it.