linux-kernel - Re: [PATCH net-next v2 0/9] net: convert drivers to .get_rx_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdeb577e-e674-493a-8dfa-d6f547cbaa50@amd.com>
Date: Thu, 22 Jan 2026 10:50:55 -0800
From: "Creeley, Brett" <bcreeley@....com>
To: Breno Leitao <leitao@...ian.org>,
 Ajit Khaparde <ajit.khaparde@...adcom.com>,
 Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
 Somnath Kotur <somnath.kotur@...adcom.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Igor Russkikh <irusskikh@...vell.com>, Simon Horman <horms@...nel.org>,
 "K. Y. Srinivasan" <kys@...rosoft.com>,
 Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
 Dexuan Cui <decui@...rosoft.com>, Long Li <longli@...rosoft.com>,
 Alexander Duyck <alexanderduyck@...com>, kernel-team@...a.com,
 Edward Cree <ecree.xilinx@...il.com>, Brett Creeley <brett.creeley@....com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 oss-drivers@...igine.com, linux-hyperv@...r.kernel.org,
 linux-net-drivers@....com, Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [PATCH net-next v2 0/9] net: convert drivers to
 .get_rx_ring_count (last part)

On 1/22/2026 10:40 AM, Breno Leitao wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Commit 84eaf4359c36 ("net: ethtool: add get_rx_ring_count callback to
> optimize RX ring queries") added specific support for GRXRINGS callback,
> simplifying .get_rxnfc.
>
> Remove the handling of GRXRINGS in .get_rxnfc() by moving it to the new
> .get_rx_ring_count().
>
> This simplifies the RX ring count retrieval and aligns the following
> drivers with the new ethtool API for querying RX ring parameters.
>
>   * sfc
>   * ionic
>   * sfc/siena
>   * sfc/ef100
>   * fbnic
>   * mana
>   * nfp
>   * atlantic
>   * benet (this is v2 in fact, where v1 had some discussions that
>     required a v2). See link [0]
>
> Link: https://lore.kernel.org/all/20260119094514.5b12a097@kernel.org/ [0]
>
> This is covering the last drivers, and as soon as this lands, I will
> change the ethtool framework to avoid calling .get_rx_ring_count for
> ETHTOOL_GRXRINGS, simplifying the ethtool core framework.
>
> Part 1 is already merged in net-next and can be seen in
> https://lore.kernel.org/all/20260109-grxring_big_v1-v1-0-a0f77f732006@debian.org/
>
> Part 2 is already merged in net-next except benet driver, which is now included
> in here
> https://lore.kernel.org/all/20260115-grxring_big_v2-v1-0-b3e1b58bced5@debian.org/
>
> PS: all of these change were compile-tested only.
>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
> Changes in v2:
> - Respect reverse xmas tree in Atlantic driver (Brett Creeley)
> - Link to v1: https://patch.msgid.link/20260121-grxring_big_v4-v1-0-07655be56bcf@debian.org
>
> ---
> Breno Leitao (9):
>        net: benet: convert to use .get_rx_ring_count
>        net: atlantic: convert to use .get_rx_ring_count
>        net: nfp: convert to use .get_rx_ring_count
>        net: mana: convert to use .get_rx_ring_count
>        net: fbnic: convert to use .get_rx_ring_count
>        net: ionic: convert to use .get_rx_ring_count
>        net: sfc: efx: convert to use .get_rx_ring_count
>        net: sfc: siena: convert to use .get_rx_ring_count
>        net: sfc: falcon: convert to use .get_rx_ring_count
>
>   .../net/ethernet/aquantia/atlantic/aq_ethtool.c    | 18 +++++++----
>   drivers/net/ethernet/emulex/benet/be_ethtool.c     | 37 ++++++++--------------
>   drivers/net/ethernet/meta/fbnic/fbnic_ethtool.c    | 12 ++++---
>   drivers/net/ethernet/microsoft/mana/mana_ethtool.c | 13 ++------
>   .../net/ethernet/netronome/nfp/nfp_net_ethtool.c   | 11 +++++--
>   .../net/ethernet/pensando/ionic/ionic_ethtool.c    | 18 ++---------
>   drivers/net/ethernet/sfc/ef100_ethtool.c           |  1 +
>   drivers/net/ethernet/sfc/ethtool.c                 |  1 +
>   drivers/net/ethernet/sfc/ethtool_common.c          | 11 ++++---
>   drivers/net/ethernet/sfc/ethtool_common.h          |  1 +
>   drivers/net/ethernet/sfc/falcon/ethtool.c          | 12 ++++---
>   drivers/net/ethernet/sfc/siena/ethtool.c           |  1 +
>   drivers/net/ethernet/sfc/siena/ethtool_common.c    | 11 ++++---
>   drivers/net/ethernet/sfc/siena/ethtool_common.h    |  1 +
>   14 files changed, 75 insertions(+), 73 deletions(-)
> ---
> base-commit: d8f87aa5fa0a4276491fa8ef436cd22605a3f9ba
> change-id: 20260121-grxring_big_v4-55037f9e001e
>
> Best regards,
> --
> Breno Leitao <leitao@...ian.org>

Entire series LGTM.

Reviewed-by: Brett Creeley <brett.creeley@....com>
>