linux-kernel - Re: [PATCH v14 09/34] PCI/AER: Export pci_aer_unmask_internal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXJxxYrIoOMKIl7W@wunner.de>
Date: Thu, 22 Jan 2026 19:51:49 +0100
From: Lukas Wunner <lukas@...ner.de>
To: dan.j.williams@...el.com
Cc: Terry Bowman <terry.bowman@....com>, dave@...olabs.net,
	jonathan.cameron@...wei.com, dave.jiang@...el.com,
	alison.schofield@...el.com, bhelgaas@...gle.com,
	shiju.jose@...wei.com, ming.li@...omail.com,
	Smita.KoralahalliChannabasappa@....com, rrichter@....com,
	dan.carpenter@...aro.org, PradeepVineshReddy.Kodamati@....com,
	Benjamin.Cheatham@....com,
	sathyanarayanan.kuppuswamy@...ux.intel.com,
	linux-cxl@...r.kernel.org, vishal.l.verma@...el.com,
	alucerop@....com, ira.weiny@...el.com, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH v14 09/34] PCI/AER: Export
 pci_aer_unmask_internal_errors()

On Thu, Jan 22, 2026 at 08:48:36AM -0800, dan.j.williams@...el.com wrote:
> Lukas Wunner wrote:
> > As said, the "xe" driver needs to unmask Internal Errors and could
> > take advantage of this helper, so I'd call opening this up for PCI
> > drivers if not a goal then at least a "desirable side effect". ;)
> > 
> > https://lore.kernel.org/all/aR1_M_i3yIygd8v-@wunner.de/
> 
> I missed that earlier. How did xe manage to be the only device in the history
> of Linux that needs internal errors unmasked?
> 
> What happens if Linux says "no, that error model has never been supported and
> it creates in ongoing mental / maintenance load of internal errors do not
> matter for PCIe, only CXL, (except xe)."

Every spec-defined feature is fair game to be used by drivers and
denying them support would seem unreasonable.

> > >     -+EXPORT_SYMBOL_GPL(pci_aer_unmask_internal_errors);
> > >       
> > >     ++/*
> > >     ++ * Internal errors are too device-specific to enable generally, however for CXL
> > >     ++ * their behavior is standardized for conveying CXL protocol errors.
> > >     ++ */
> > >     ++EXPORT_SYMBOL_FOR_MODULES(pci_aer_unmask_internal_errors, "cxl_core");
> > >     ++
> > 
> > This change will require touching aer.c every time a driver
> > (such as xe) has the need to unmask Internal Errors.
> > Not sure if that's such a good idea...
> 
> The xe driver can always come back and change this to plain
> EXPORT_SYMBOL_GPL() once the clear the hurdle above of,
> "please reconsider your error model to not require this
> never needed before feature of AER".

Of course, but it may annoy Bjorn that he'll have to deal with
an amendment of this macro for each individual driver that needs it,
or at least for the *next* driver that needs it.

Thanks,

Lukas