linux-kernel - Re: [PATCH v2 2/2] arm64: dts: socfpga: stratix10: Add emmc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260122-carnival-mandatory-91115c410d74@spud>
Date: Thu, 22 Jan 2026 19:04:03 +0000
From: Conor Dooley <conor@...nel.org>
To: tzeyee.ng@...era.com
Cc: Dinh Nguyen <dinguyen@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: socfpga: stratix10: Add emmc support

On Thu, Jan 22, 2026 at 05:47:43AM -0800, tzeyee.ng@...era.com wrote:
> From: Ng Tze Yee <tzeyee.ng@...era.com>
> 
> The Stratix10 devkit supports a separate eMMC daughter card. The eMMC
> daughter card replaces the SDMMC slot that is on the default daughter card
> and thus requires a separate board dts file.
> 
> Signed-off-by: Ng Tze Yee <tzeyee.ng@...era.com>
> ---
> Changes in v2:
> - Introduced socfpga_stratix10_socdk.dtsi for common board settings
> - Updated socfpga_stratix10_socdk_emmc.dts to include the new dtsi
> - Added fallback compatible string "altr,socfpga-stratix10-socdk" in
>   the socfpga_stratix10_socdk_emmc.dts

You forgot to modify the existing socdk dts to use the common dtsi,
as-is you've just moved the duplication to a different file.

> ---
>  arch/arm64/boot/dts/altera/Makefile           |   1 +
>  .../dts/altera/socfpga_stratix10_socdk.dtsi   | 131 ++++++++++++++++++
>  .../altera/socfpga_stratix10_socdk_emmc.dts   |  21 +++
>  3 files changed, 153 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtsi
>  create mode 100644 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_emmc.dts

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)