linux-kernel - Re: [PATCH v14 11/34] PCI/AER: Move CXL RCH error handling to aer_cxl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7260b8d-7654-4e85-bc35-da23c55b3ba7@amd.com>
Date: Thu, 22 Jan 2026 14:05:14 -0600
From: "Bowman, Terry" <terry.bowman@....com>
To: Markus Elfring <Markus.Elfring@....de>, linux-pci@...r.kernel.org,
 linux-cxl@...r.kernel.org, Alejandro Lucero Palau <alucerop@....com>,
 Alison Schofield <alison.schofield@...el.com>,
 Benjamin Cheatham <benjamin.cheatham@....com>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Dan Carpenter
 <dan.carpenter@...aro.org>, Dan Williams <dan.j.williams@...el.com>,
 Dave Jiang <dave.jiang@...el.com>, Davidlohr Bueso <dave@...olabs.net>,
 Ira Weiny <ira.weiny@...el.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>,
 Lukas Wunner <lukas@...ner.de>, Li Ming <ming.li@...omail.com>,
 Pradeep Vinesh Reddy Kodamati <PradeepVineshReddy.Kodamati@....com>,
 Robert Richter <rrichter@....com>, Shiju Jose <shiju.jose@...wei.com>,
 Smita Koralahalli <Smita.KoralahalliChannabasappa@....com>,
 Vishal Verma <vishal.l.verma@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 11/34] PCI/AER: Move CXL RCH error handling to
 aer_cxl_rch.c

On 1/22/2026 11:23 AM, Markus Elfring wrote:
> …
>> +++ b/drivers/accel/thames/thames_gem.c
>> @@ -0,0 +1,353 @@
> …
>> +static int cxl_rch_handle_error_iter(struct pci_dev *dev, void *data)
>> +{
> …
>> +	device_lock(&dev->dev);
>> +
>> +	err_handler = dev->driver ? dev->driver->err_handler : NULL;
> …
>> +out:
>> +	device_unlock(&dev->dev);
>> +	return 0;
>> +}
> …
> 
> Under which circumstances would you become interested to apply a statement
> like “guard(device)(&dev->dev);”?
> https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/device.h#L913
> 
> Regards,
> Markus

Hi Markus,

This patch was a move (leaving the lock/unlock calls intact). I change 
the lock/unlock to guard() in the following patch, after the move:

PCI/AER: Use guard() in cxl_rch_handle_error_iter()                             

-Terry