linux-kernel - Re: [PATCH] ACPI: x86: s2idle: Remove dead code in lps0_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0i=QA+A7nxquKoDtKVNBRGRZAzGOQGs-KHH9d3xkrmN6Q@mail.gmail.com>
Date: Thu, 22 Jan 2026 21:47:17 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Mario Limonciello <superm1@...nel.org>, Gergo Koteles <soyer@....hu>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: x86: s2idle: Remove dead code in lps0_device_attach()

On Fri, Jan 9, 2026 at 5:19 PM Mario Limonciello <superm1@...nel.org> wrote:
>
> On 1/8/26 6:16 PM, Gergo Koteles wrote:
> > The rev_id is always 0 for AMD since commit
> > e32d546483a2 ("ACPI: x86: Drop quirk for HP Elitebook"),
> > so this condition will never be true.
> >
> > Remove the dead code.
> >
> > Signed-off-by: Gergo Koteles <soyer@....hu>
>
> Makes sense, thanks!
>
> Reviewed-by: Mario Limonciello (AMD) <superm1@...nel.org>

Applied as 6.20 material, thanks!

> > ---
> >   drivers/acpi/x86/s2idle.c | 3 ---
> >   1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/acpi/x86/s2idle.c b/drivers/acpi/x86/s2idle.c
> > index 6d4d06236f61..a095b6f4401b 100644
> > --- a/drivers/acpi/x86/s2idle.c
> > +++ b/drivers/acpi/x86/s2idle.c
> > @@ -459,9 +459,6 @@ static int lps0_device_attach(struct acpi_device *adev,
> >                       lps0_dsm_func_mask = (lps0_dsm_func_mask << 1) | 0x1;
> >                       acpi_handle_debug(adev->handle, "_DSM UUID %s: Adjusted function mask: 0x%x\n",
> >                                         ACPI_LPS0_DSM_UUID_AMD, lps0_dsm_func_mask);
> > -             } else if (lps0_dsm_func_mask_microsoft > 0 && rev_id) {
> > -                     lps0_dsm_func_mask_microsoft = -EINVAL;
> > -                     acpi_handle_debug(adev->handle, "_DSM Using AMD method\n");
> >               }
> >       } else {
> >               rev_id = 1;
>