linux-kernel - Re: [PATCH v2 1/2] rust: task: use `as_char_ptr` instead of `as

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9=h7_3fBCo9SGLxv0VAvmFuSD3jRF3rtCaKe7izqHNckA@mail.gmail.com>
Date: Thu, 22 Jan 2026 17:33:36 -0500
From: Tamir Duberstein <tamird@...nel.org>
To: Gary Guo <gary@...yguo.net>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Panagiotis Foliadis <pfoliadis@...teo.net>, 
	Shankari Anand <shankari.ak0208@...il.com>, FUJITA Tomonori <fujita.tomonori@...il.com>, 
	kernel test robot <lkp@...el.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rust: task: use `as_char_ptr` instead of `as_ptr().cast()`

On Thu, Jan 22, 2026 at 9:56 AM Gary Guo <gary@...yguo.net> wrote:
>
> On Thu Jan 22, 2026 at 2:44 PM GMT, Gary Guo wrote:
> > From: Gary Guo <gary@...yguo.net>
> >
> > `as_char_ptr` would provide the correct (unsigned char) type without
> > needing to convert to an intermediate type and cast the pointer.
> >
> > The `as_ptr()` function is going to be disallowed by clippy warning, so fix
> > this usage.
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202601221157.89t3Sqbl-lkp@intel.com/
> > Signed-off-by: Gary Guo <gary@...yguo.net>

Reviewed-by: Tamir Duberstein <tamird@...nel.org>