linux-kernel - Re: [PATCH 1/1] kasan: remove unnecessary sync argument from start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZe+J-G-g594hXZf2G0BMoCuRbe0yM-gsxxQZSymyx8_MQ@mail.gmail.com>
Date: Thu, 22 Jan 2026 23:51:11 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Maninder Singh <maninder1.s@...sung.com>
Cc: ryabinin.a.a@...il.com, glider@...gle.com, dvyukov@...gle.com, 
	vincenzo.frascino@....com, akpm@...ux-foundation.org, 
	kasan-dev@...glegroups.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] kasan: remove unnecessary sync argument from start_report()

On Thu, Jan 22, 2026 at 5:16 AM Maninder Singh <maninder1.s@...sung.com> wrote:
>
> commit 7ce0ea19d50e ("kasan: switch kunit tests to console tracepoints")
> removed use of sync variable, thus removing that extra argument also.
>
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> ---
>  mm/kasan/report.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/kasan/report.c b/mm/kasan/report.c
> index 62c01b4527eb..27efb78eb32d 100644
> --- a/mm/kasan/report.c
> +++ b/mm/kasan/report.c
> @@ -203,7 +203,7 @@ static inline void fail_non_kasan_kunit_test(void) { }
>
>  static DEFINE_RAW_SPINLOCK(report_lock);
>
> -static void start_report(unsigned long *flags, bool sync)
> +static void start_report(unsigned long *flags)
>  {
>         fail_non_kasan_kunit_test();
>         /* Respect the /proc/sys/kernel/traceoff_on_warning interface. */
> @@ -543,7 +543,7 @@ void kasan_report_invalid_free(void *ptr, unsigned long ip, enum kasan_report_ty
>         if (unlikely(!report_enabled()))
>                 return;
>
> -       start_report(&flags, true);
> +       start_report(&flags);
>
>         __memset(&info, 0, sizeof(info));
>         info.type = type;
> @@ -581,7 +581,7 @@ bool kasan_report(const void *addr, size_t size, bool is_write,
>                 goto out;
>         }
>
> -       start_report(&irq_flags, true);
> +       start_report(&irq_flags);
>
>         __memset(&info, 0, sizeof(info));
>         info.type = KASAN_REPORT_ACCESS;
> @@ -615,7 +615,7 @@ void kasan_report_async(void)
>         if (unlikely(!report_enabled()))
>                 return;
>
> -       start_report(&flags, false);
> +       start_report(&flags);
>         pr_err("BUG: KASAN: invalid-access\n");
>         pr_err("Asynchronous fault: no details available\n");
>         pr_err("\n");
> --
> 2.34.1
>

Reviewed-by: Andrey Konovalov <andreyknvl@...il.com>

Thanks!