[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL_JsqLuN0ZJx2hJTqGjBHNR-hUWCoDoY-D-VPWFW8JBEMT3sA@mail.gmail.com>
Date: Thu, 22 Jan 2026 17:00:16 -0600
From: Rob Herring <robh@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
Pankaj Patil <pankaj.patil@....qualcomm.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Maulik Shah <maulik.shah@....qualcomm.com>,
Taniya Das <taniya.das@....qualcomm.com>,
Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@....qualcomm.com>,
Jyothi Kumar Seerapu <jyothi.seerapu@....qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>, Bjorn Andersson <andersson@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Sibi Sankar <sibi.sankar@....qualcomm.com>,
Konrad Dybcio <konradybcio@...nel.org>, Qiang Yu <qiang.yu@....qualcomm.com>,
Jishnu Prakash <jishnu.prakash@....qualcomm.com>, Conor Dooley <conor+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>, linux-arm-msm@...r.kernel.org,
Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>, Abel Vesa <abelvesa@...nel.org>
Subject: Re: [PATCH v6 0/4] arm64: dts: qcom: Introduce Glymur SoC dtsi and
Glymur CRD dts
On Thu, Jan 22, 2026 at 2:41 PM Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 1/22/26 7:07 PM, Rob Herring wrote:
> >
> > On Thu, 22 Jan 2026 20:53:57 +0530, Pankaj Patil wrote:
> >> Introduce dt-bindings and initial device tree support for Glymur,
> >> Qualcomm's next-generation compute SoC and it's associated
> >> Compute Reference Device (CRD) platform.
> >>
> >> https://www.qualcomm.com/products/mobile/snapdragon/laptops-and-tablets/snapdragon-x2-elite
> >> https://www.qualcomm.com/news/releases/2025/09/new-snapdragon-x2-elite-extreme-and-snapdragon-x2-elite-are-the-
> >>
> >> The base support enables booting to shell with rootfs on NVMe,
> >> demonstrating functionality for PCIe and NVMe subsystems.
> >> DCVS is also enabled, allowing dynamic frequency scaling for the CPUs.
> >> TSENS (Thermal Sensors) enabled for monitoring SoC temperature and
> >> thermal management. The platform is capable of booting kernel at EL2
> >> with kvm-unit tests performed on it for sanity.
> >>
> >> Added dtsi files for the PMIC's enabled PMH0101, PMK8850, PMCX0102,
> >> SMB2370, PMH0104, PMH0110 along with temp-alarm and GPIO nodeS.
> >>
> >> For CPU compatible naming, there is one discussion which is not specific
> >> to Glymur, Kaanapali and Glymur use the same Oryon cores.
> >> https://lore.kernel.org/all/20251119-oryon-binding-v1-1-f79a101b0391@oss.qualcomm.com/
> >> We've kept the "qcom,oryon" compatible
> >>
> >> Features enabled in this patchset:
> >> 1. NVMe storage support
> >> 2. PCIe controller and PCIe PHY
> >> 3. RPMH Regulators
> >> 4. Clocks and reset controllers - GCC, TCSRCC, DISPCC, RPMHCC
> >> 5. Interrupt controller
> >> 6. TLMM (Top-Level Mode Multiplexer)
> >> 7. QUP Block
> >> 8. Reserved memory regions
> >> 9. PMIC support with regulators
> >> 10. CPU Power Domains
> >> 11. TSENS (Thermal Sensors)
> >> 12. DCVS: CPU DCVS with scmi perf protocol
> >>
> >> Dependencies:
> >>
> >> dt-bindings:
> >> 1. https://lore.kernel.org/all/20260121-glymur-pmic-mfd-v1-1-2aab4f21e79c@oss.qualcomm.com/
> >> 2. https://lore.kernel.org/all/20251215-knp-pmic-leds-v3-2-5e583f68b0e5@oss.qualcomm.com/
> >> 3. https://lore.kernel.org/all/20260121110828.2267061-1-pankaj.patil@oss.qualcomm.com/
> >> 4. https://lore.kernel.org/all/20260111155234.5829-1-pankaj.patil@oss.qualcomm.com/
> >>
> >> Linux-next based tree with Glymur patches is available at:
> >> https://git.codelinaro.org/clo/linux-kernel/kernel-qcom/-/tree/b4/v6_glymur_introduction
> >>
> >> Signed-off-by: Pankaj Patil <pankaj.patil@....qualcomm.com>
> >> ---
> >> Changes in v6:
> >> - Moved pmic thermal zones to their respective pmic dtsi files
> >> - Link to v5: https://lore.kernel.org/r/20260122-upstream_v3_glymur_introduction-v5-0-8ba76c354e9a@oss.qualcomm.com
> >>
> >> Changes in v5:
> >> - Added opp entries for pcie nodes
> >> - Dropped qup-memory interconnect from uart nodes
> >> - Update trip1 type to critical for pmic thermal zones
> >> - Alignment and newline fixes according to comments
> >> - Link to v4: https://lore.kernel.org/r/20260112-upstream_v3_glymur_introduction-v4-0-8a0366210e02@oss.qualcomm.com
> >>
> >> Changes in v4:
> >> - Enabled PCIe SMMU for all 4 PCIe instances
> >> - Updated dispcc required opps level to "rpmhpd_opp_low_svs"
> >> - Updated watchdog compatible
> >> - Renamed gic-its to msi-controller
> >> - Updated GCC clocks property to 43 from 44
> >> - Moved cpu-idle-states to domain-idle-states
> >> - Fixed alignment and zero padding issues according to review comments
> >> - Dropped glymur-pmics.dtsi
> >> - Moved pmic thermal zones from board dts to soc dtsi
> >> - Link to v3: https://lore.kernel.org/r/20251219-upstream_v3_glymur_introduction-v3-0-32271f1f685d@oss.qualcomm.com
> >>
> >> Changes in v3:
> >> - Enabled system-cache-controller
> >> - Squashed all initial features to boot to shell with nvme as storage
> >> - Updated tsens nodes according to comments
> >> - Merged tcsr and tcsrcc node
> >> - Addressed review comments
> >> - Link to v1: https://lore.kernel.org/all/20250925-v3_glymur_introduction-v1-0-24b601bbecc0@oss.qualcomm.com
> >>
> >> Changes in v2:
> >> - Series was sent erroneously
> >> - Link to v1: https://lore.kernel.org/r/20250925-v3_glymur_introduction-v1-0-5413a85117c6@oss.qualcomm.com
> >>
> >> Signed-off-by: Pankaj Patil <pankaj.patil@....qualcomm.com>
> >>
> >> ---
> >> Pankaj Patil (4):
> >> dt-bindings: arm: qcom: Document Glymur SoC and board
> >> arm64: defconfig: Enable Glymur configs for boot to shell
> >> arm64: dts: qcom: Introduce Glymur base dtsi
> >> arm64: dts: qcom: glymur: Enable Glymur CRD board support
> >>
> >> Documentation/devicetree/bindings/arm/qcom.yaml | 5 +
> >> arch/arm64/boot/dts/qcom/Makefile | 1 +
> >> arch/arm64/boot/dts/qcom/glymur-crd.dts | 601 +++
> >> arch/arm64/boot/dts/qcom/glymur.dtsi | 5913 +++++++++++++++++++++++
> >> arch/arm64/boot/dts/qcom/pmcx0102.dtsi | 187 +
> >> arch/arm64/boot/dts/qcom/pmh0101.dtsi | 68 +
> >> arch/arm64/boot/dts/qcom/pmh0104-glymur.dtsi | 144 +
> >> arch/arm64/boot/dts/qcom/pmh0110-glymur.dtsi | 144 +
> >> arch/arm64/boot/dts/qcom/pmk8850.dtsi | 70 +
> >> arch/arm64/boot/dts/qcom/smb2370.dtsi | 45 +
> >> arch/arm64/configs/defconfig | 5 +
> >> 11 files changed, 7183 insertions(+)
> >> ---
> >> base-commit: 46fe65a2c28ecf5df1a7475aba1f08ccf4c0ac1b
> >> change-id: 20251007-upstream_v3_glymur_introduction-5a105b54493d
> >> prerequisite-message-id: <20260121-glymur-pmic-mfd-v1-1-2aab4f21e79c@....qualcomm.com>
> >> prerequisite-patch-id: bd5a4703a5a7fc530418337680cf1e2ea1518f35
> >> prerequisite-message-id: <20251215-knp-pmic-leds-v3-0-5e583f68b0e5@....qualcomm.com>
> >> prerequisite-patch-id: 6bbaff642cfd1f1386ff0ccd746739b68cdbeb45
> >> prerequisite-patch-id: e30603778b23b7f7586b1c01a362e45af7bd0aa3
> >> prerequisite-message-id: <20260121110828.2267061-1-pankaj.patil@....qualcomm.com>
> >> prerequisite-patch-id: 14469fd166b31b251b98bf25e783ab6f57ddd13a
> >>
> >> Best regards,
> >> --
> >> Pankaj Patil <pankaj.patil@....qualcomm.com>
> >>
> >>
> >>
> >
> >
> > My bot found new DTB warnings on the .dts files added or changed in this
> > series.
> >
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> > are fixed by another series. Ultimately, it is up to the platform
> > maintainer whether these warnings are acceptable or not. No need to reply
> > unless the platform maintainer has comments.
> >
> > If you already ran DT checks and didn't see these error(s), then
> > make sure dt-schema is up to date:
> >
> > pip3 install dtschema --upgrade
> >
> >
> > This patch series was applied (using b4) to base:
> > Deps: looking for dependencies matching 4 patch-ids
> > Deps: Applying prerequisite patch: [PATCH] dt-bindings: mfd: qcom,spmi-pmic: Document PMICs present on Glymur
> > Deps: Applying prerequisite patch: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM
> > Deps: Applying prerequisite patch: [PATCH v3 2/2] dt-bindings: leds: qcom,spmi-flash-led: Add PMH0101 compatible
> > Deps: Applying prerequisite patch: [PATCH v2] dt-bindings: dma: qcom,gpi: Update max interrupt lines to 16
> > Base: 46fe65a2c28ecf5df1a7475aba1f08ccf4c0ac1b (use --merge-base to override)
> >
> > If this is not the correct base, please add 'base-commit' tag
> > (or use b4 which does this automatically)
> >
> >
> > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260122-upstream_v3_glymur_introduction-v6-0-245f408ed82a@....qualcomm.com:
> >
> > arch/arm64/boot/dts/qcom/glymur-crd.dtb: pci@...0000 (qcom,glymur-pcie): compatible:0: 'qcom,pcie-x1e80100' was expected
> > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-x1e80100.yaml
>
> +Mani you sent a 'b4 ty' for this months ago, what happened?
>
> https://lore.kernel.org/linux-arm-msm/176189884156.5303.14323602106505981794.b4-ty@kernel.org/
It wasn't in 1/16 linux-next, but it is there now.
> The ipcc one should be handled by Rob now:
>
> https://lore.kernel.org/linux-arm-msm/20260116162057.GA1681736-robh@kernel.org/
Actually, Bjorn picked that up instead since there are other mailbox
patches that didn't get picked up.
> And watchdog is perhaps in Guenter's queue
>
> https://lore.kernel.org/linux-arm-msm/de7f0b8a-a355-42c1-ac3c-d0b5de754711@roeck-us.net/
Seems to be hit or miss if wdog bindings are picked up, but again,
this one is in today's next.
Perhaps slow down the pace on this given the 4 listed dependencies and
3 unlisted dependencies.
Rob
Powered by blists - more mailing lists