linux-kernel - Re: [PATCH net-next v01 1/5] hinic3: Fix netif_queue_set_napi queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260121201145.537a6726@kernel.org>
Date: Wed, 21 Jan 2026 20:11:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Fan Gong <gongfan1@...wei.com>
Cc: Zhu Yikai <zhuyikai1@...artners.com>, <netdev@...r.kernel.org>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, <linux-kernel@...r.kernel.org>,
 <linux-doc@...r.kernel.org>, luosifu <luosifu@...wei.com>, Xin Guo
 <guoxin09@...wei.com>, Zhou Shuai <zhoushuai28@...wei.com>, Wu Like
 <wulike1@...wei.com>, Shi Jing <shijing34@...wei.com>, Luo Yang
 <luoyang82@...artners.com>
Subject: Re: [PATCH net-next v01 1/5] hinic3: Fix netif_queue_set_napi
 queue_index parameter passing error

On Tue, 20 Jan 2026 22:29:47 +0800 Fan Gong wrote:
> Incorrectly transmitted interrupt number instead of queue number
> when using netif_queue_set_napi. Besides, move this to appropriate
> code location.
> Remove redundant netif_stop_subqueue beacuase it is not part of the
> hinic3_send_one_skb process.

The NAPI <> queue mapping is exposed to user space via the netdev
Netlink family. I think this deserves to be treated as a fix and
submitted to net with a Fixes tag. The rest of the patches LGTM
for net-next.
-- 
pw-bot: cr