linux-kernel - Re: [PATCH v2] cpufreq: qcom-nvmem: add sentinel to qcom_cpufreq_ipq806x_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6kykizeqega4wsps25katcdhsavr2ktbbcn3clbgkdqgip2k4u@azxr5ryitlkv>
Date: Thu, 22 Jan 2026 13:00:39 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: rafael@...nel.org, xiaopeitux@...mail.com
Cc: konrad.dybcio@....qualcomm.com, ilia.lin@...nel.org, 
	linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Pei Xiao <xiaopei01@...inos.cn>
Subject: Re: [PATCH v2] cpufreq: qcom-nvmem: add sentinel to
 qcom_cpufreq_ipq806x_match_list

On 22-01-26, 09:44, xiaopeitux@...mail.com wrote:
> From: Pei Xiao <xiaopei01@...inos.cn>
> 
> The of_device_id table is expected to be NULL-terminated. Without the
> sentinel, the traversal of the array can lead to out-of-bound access,
> causing undefined behavior.
> 
> This adds the missing sentinel to the qcom_cpufreq_ipq806x_match_list
> array.
> 
> Fixes: 58f5d39d5ed8 ("cpufreq: qcom-nvmem: add compatible fallback for ipq806x for no SMEM")
> Signed-off-by: Pei Xiao <xiaopei01@...inos.cn>
> ---
> changlog in v2:
> Remove the extra commas
> ---
>  drivers/cpufreq/qcom-cpufreq-nvmem.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index 81e16b5a0245..b8081acba928 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -263,6 +263,7 @@ static const struct of_device_id qcom_cpufreq_ipq806x_match_list[] __maybe_unuse
>  	{ .compatible = "qcom,ipq8066", .data = (const void *)QCOM_ID_IPQ8066 },
>  	{ .compatible = "qcom,ipq8068", .data = (const void *)QCOM_ID_IPQ8068 },
>  	{ .compatible = "qcom,ipq8069", .data = (const void *)QCOM_ID_IPQ8069 },
> +	{ /* sentinel */ }
>  };
>  
>  static int qcom_cpufreq_ipq8064_name_version(struct device *cpu_dev,

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Rafael, can you take this directly for rc7 ?

-- 
viresh