linux-kernel - Re: [PATCH 1/2] dt-bindings: trivial-devices: Add jedec,pmic50x0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260122-fair-aloof-dove-0f1fe3@quoll>
Date: Thu, 22 Jan 2026 09:10:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Almog Ben Shaul <almogbs@...zon.com>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, itamark@...zon.com, talel@...zon.com, 
	farbere@...zon.com, ayalstei@...zon.com, dwmw@...zon.com
Subject: Re: [PATCH 1/2] dt-bindings: trivial-devices: Add jedec,pmic50x0

On Wed, Jan 21, 2026 at 03:19:46PM +0000, Almog Ben Shaul wrote:
> Add devicetree binding for JEDEC PMIC50x0 compliant I2C DDR5 PMICs.
> https://www.jedec.org/standards-documents/docs/jesd301-1a03
> 
> Signed-off-by: Almog Ben Shaul <almogbs@...zon.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)

You did not Cc any maintainers, but you Cc-ed 5 Amazon people. Great.

Drop unrelated Cc list and start using kernel tools for development.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about 'b4 prep --auto-to-cc' if you added new
patches to the patchset.

> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index d0f7dbf15d6f..fb16bd91c76c 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -171,6 +171,8 @@ properties:
>            - isil,isl76682
>              # JEDEC JESD300 (SPD5118) Hub and Serial Presence Detect
>            - jedec,spd5118
> +            # JEDEC PMIC50X0 DDR5 Power Management ICs
> +          - jedec,pmic50x0

Mis ordered. s > p

Best regards,
Krzysztof