linux-kernel - Re: [PATCH] bus: ti-sysc: fix reference count leak in sysc_init_static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260122093537.253592e9@kemnade.info>
Date: Thu, 22 Jan 2026 09:35:37 +0100
From: Andreas Kemnade <andreas@...nade.info>
To: Weigang He <geoffreyhe2@...il.com>
Cc: tony@...mide.com, aaro.koskinen@....fi, khilman@...libre.com,
 rogerq@...nel.org, linux-omap@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] bus: ti-sysc: fix reference count leak in
 sysc_init_static_data()

On Sat, 17 Jan 2026 06:22:35 +0000
Weigang He <geoffreyhe2@...il.com> wrote:

> of_find_node_by_path() returns a device_node with refcount incremented.
> The reference to the "/ocp" node is acquired for a WARN_ONCE check but
> is never released with of_node_put(), causing a reference count leak.
> 
> Add of_node_put(np) after the WARN_ONCE check to properly release the
> "/ocp" node reference.
> 
> Fixes: 5f7259a578e9 ("bus: ti-sysc: Check for old incomplete dtb")
> Cc: stable@...r.kernel.org
> Signed-off-by: Weigang He <geoffreyhe2@...il.com>

Reviewed-by: Andreas Kemnade <andreas@...nade.info>