linux-kernel - Re: [PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <732a8967-4d87-4c5d-905f-cdc0629e9946@kernel.org>
Date: Thu, 22 Jan 2026 10:50:03 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ben Zong-You Xie <ben717@...estech.com>
Cc: Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <pjw@...nel.org>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, linux-i2c@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: i2c: add support for AE350 I2C
 controller

On 22/01/2026 09:08, Krzysztof Kozlowski wrote:
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - items:
>> +          - enum:
>> +              - andestech,qilai-i2c
>> +          - const: andestech,ae350-i2c
>> +      - const: andestech,ae350-i2c
> 
> Same question as before. Nothing in commit msg explains me above and you
> STILL DID NOT send your soc upstream which would help me to understand

To clarify: no top-level bindings for `git grep andestech,ae350`

> the relation between SoCs.
> 
> Considering you did not even build check previous version, I do not give
> you any benefits of the doubt that this is correct code.
> 
> Respond to previous review.
> 
> That is a NAK and I am dropping it from the patchwork.



Best regards,
Krzysztof