linux-kernel - Re: [PATCH] powerpc/vdso: Provide clock_getres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260122104257-3124dc96-5916-4d25-bbce-9b868b30ee18@linutronix.de>
Date: Thu, 22 Jan 2026 10:50:42 +0100
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
Cc: "npiggin@...il.com" <npiggin@...il.com>, 
	"luto@...nel.org" <luto@...nel.org>, "chleroy@...nel.org" <chleroy@...nel.org>, 
	"maddy@...ux.ibm.com" <maddy@...ux.ibm.com>, "tglx@...nel.org" <tglx@...nel.org>, 
	"mpe@...erman.id.au" <mpe@...erman.id.au>, "vincenzo.frascino@....com" <vincenzo.frascino@....com>, 
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/vdso: Provide clock_getres_time64()

Hi Alexander,

On Thu, Jan 22, 2026 at 09:39:09AM +0000, Sverdlin, Alexander wrote:
> Hi Thomas, Christophe,
> 
> On Wed, 2026-01-14 at 08:26 +0100, Thomas Weißschuh wrote:
> > For consistency with __vdso_clock_gettime64() there should also be a
> > 64-bit variant of clock_getres(). This will allow the extension of
> > CONFIG_COMPAT_32BIT_TIME to the vDSO and finally the removal of 32-bit
> > time types from the kernel and UAPI.
> > 
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> 
> I've bisected this patch to cause the following build failure on my side:
> 
>   LDS     arch/powerpc/kernel/vdso/vdso32.lds
>   VDSO32A arch/powerpc/kernel/vdso/sigtramp32-32.o
>   VDSO32A arch/powerpc/kernel/vdso/gettimeofday-32.o
>   VDSO32A arch/powerpc/kernel/vdso/datapage-32.o
>   VDSO32A arch/powerpc/kernel/vdso/cacheflush-32.o
>   VDSO32A arch/powerpc/kernel/vdso/note-32.o
>   VDSO32A arch/powerpc/kernel/vdso/getcpu-32.o
>   VDSO32A arch/powerpc/kernel/vdso/getrandom-32.o
>   VDSO32A arch/powerpc/kernel/vdso/vgetrandom-chacha-32.o
>   VDSO32C arch/powerpc/kernel/vdso/vgettimeofday-32.o
>   VDSO32C arch/powerpc/kernel/vdso/vgetrandom-32.o
>   VDSO32A arch/powerpc/kernel/vdso/crtsavres-32.o
>   VDSO32L arch/powerpc/kernel/vdso/vdso32.so.dbg
> arch/powerpc/kernel/vdso/vdso32.so.dbg: dynamic relocations are not supported
> make[2]: *** [arch/powerpc/kernel/vdso/Makefile:79: arch/powerpc/kernel/vdso/vdso32.so.dbg] Error 1
> make[1]: *** [arch/powerpc/Makefile:388: vdso_prepare] Error 2

Thanks for the report!

> Does it ring any bells? What could I try/test?

Not immediately, but I'll look into it.

> I'm using gcc-15.2.0 and binutils 2.45.1.

Is this a toolchain from https://cdn.kernel.org/pub/tools/crosstool/ ?
Could you also share your configuration?

> > ---
> > Based on tip/timers/vdso.
> > 
> > This was missed in the original vdso_getres_time64() series as powerpc
> > does not use include/vdso/gettime.h.
> > ---
> >  arch/powerpc/include/asm/vdso/gettimeofday.h |  2 ++
> >  arch/powerpc/kernel/vdso/gettimeofday.S      | 12 ++++++++++++
> >  arch/powerpc/kernel/vdso/vdso32.lds.S        |  1 +
> >  arch/powerpc/kernel/vdso/vgettimeofday.c     |  6 ++++++
> >  4 files changed, 21 insertions(+)

(...)