linux-kernel - Re: [PATCH v3 3/6] drm/sun4i: Enable LVDS output on sun20i D1s/T113

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6825d5bf-9d99-4872-a61f-1b145bfd2efa@linumiz.com>
Date: Thu, 22 Jan 2026 11:22:00 +0100
From: Parthiban <parthiban@...umiz.com>
To: Kuba Szczodrzyński <kuba@...zodrzynski.pl>,
 Maxime Ripard <mripard@...nel.org>, Samuel Holland <samuel@...lland.org>,
 Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: parthiban@...umiz.com, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, linux-arm-kernel@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, linux-phy@...ts.infradead.org,
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 paulk@...-base.io
Subject: Re: [PATCH v3 3/6] drm/sun4i: Enable LVDS output on sun20i D1s/T113

Dear Kuba,

On 11/16/25 2:48 PM, Kuba Szczodrzyński wrote:
> +static void sun20i_tcon_setup_lvds_dphy(struct sun4i_tcon *tcon,
> +					const struct drm_encoder *encoder)
> +{
> +	union phy_configure_opts opts = { };
> +
> +	if (!tcon->quirks->has_combo_dphy || !tcon->dphy)
> +		return;
> +
> +	if (phy_init(tcon->dphy))
> +		return;
> +
> +	if (phy_set_mode(tcon->dphy, PHY_MODE_LVDS))

>From Documentation/driver-api/phy/phy.rst, set_mode shall be after power_on. But re-order
will fail to work for our case. Not sure if this is fine.

Thanks,
Parthiban

> +		return;
> +
> +	if (phy_configure(tcon->dphy, &opts))
> +		return;
> +
> +	if (phy_power_on(tcon->dphy))
> +		return;