linux-kernel - Re: kernel/liveupdate/kexec_handover.c:994 kho_preserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2vxzh5seaqhy.fsf@kernel.org>
Date: Thu, 22 Jan 2026 10:30:49 +0000
From: Pratyush Yadav <pratyush@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,  oe-kbuild@...ts.linux.dev,
  Pasha Tatashin <pasha.tatashin@...een.com>,  lkp@...el.com,
  oe-kbuild-all@...ts.linux.dev,  linux-kernel@...r.kernel.org,  Linux
 Memory Management List <linux-mm@...ck.org>,  Jason Gunthorpe
 <jgg@...dia.com>,  "Mike Rapoport (Microsoft)" <rppt@...nel.org>
Subject: Re: kernel/liveupdate/kexec_handover.c:994 kho_preserve_vmalloc()
 warn: missing error code 'err'

On Wed, Jan 21 2026, Andrew Morton wrote:

> On Wed, 21 Jan 2026 11:58:20 +0300 Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
>> Hi Pasha,
>> 
>> First bad commit (maybe != root cause):
>> 
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   6c790212c588fddeb0d852f2790840753bb604b1
>> commit: 48a1b2321d763b5edeaf20bd4576d8c4b5df772b liveupdate: kho: move to kernel/liveupdate
>> config: x86_64-randconfig-r071-20260121 (https://download.01.org/0day-ci/archive/20260121/202601211636.IRaejjdw-lkp@intel.com/config)
>> compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
>> rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
>> smatch version: v0.5.0-8985-g2614ff1a
>> 
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@...el.com>
>> | Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
>> | Closes: https://lore.kernel.org/r/202601211636.IRaejjdw-lkp@intel.com/
>> 
>> smatch warnings:
>> kernel/liveupdate/kexec_handover.c:994 kho_preserve_vmalloc() warn: missing error code 'err'
>
> Indeed, thanks.
>
>
> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: kho: kho_preserve_vmalloc(): don't return 0 when ENOMEM
> Date: Wed Jan 21 12:36:17 PM PST 2026
>
> kho_preserve_vmalloc() should return -ENOMEM when new_vmalloc_chunk()
> fails.

Thanks!

Reviewed-by: Pratyush Yadav <pratyush@...nel.org>

[...]

-- 
Regards,
Pratyush Yadav