linux-kernel - Re: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260123113529.1522424-1-lihaoxiang@isrc.iscas.ac.cn>
Date: Fri, 23 Jan 2026 19:35:29 +0800
From: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
To: ioana.ciornei@....com
Cc: chleroy@...nel.org,
	dan.carpenter@...aro.org,
	lihaoxiang@...c.iscas.ac.cn,
	linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org,
	suhui@...china.com
Subject: Re: [PATCH v2] bus: fsl-mc: fix an error handling in fsl_mc_device_add()

Hi, Ioana:

On Fri, 23 Jan 2026 13:10:46 +0200, Ioana Ciornei wrote:
> Is there any reason why you didn't go with Christophe's suggestion from
> https://lore.kernel.org/all/b7f7e968-a683-4e1e-8ccc-5dd19f0f15c5@kernel.org/ ?

> It's perfectly valid to call put_device() even though device_add() was
> not called, meaning from the other code paths.

Actually, I totally agree with that suggestion. However, I submit a same fix
several months ago and got a reply:
https://lore.kernel.org/all/2025052622-nautical-suitably-486c@gregkh/

I didn't figure out why. And if you agree with the Christophe's suggestion,
I will resubmit a patch v3.

Thanks,
Haoxiang Li