linux-kernel - Re: [PATCH] ALSA: usb-audio: add mixer support for Focusrite Forte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjikft4k.wl-tiwai@suse.de>
Date: Fri, 23 Jan 2026 12:47:23 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Jegor van Opdorp <derusproductions@...il.com>
Cc: "tiwai@...e.com" <tiwai@...e.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: add mixer support for Focusrite Forte

On Thu, 22 Jan 2026 19:42:16 +0100,
Jegor van Opdorp wrote:
> 
> 
> Hi,
> 
> Please find attached a patch adding mixer support for the Focusrite Forte (USB
> ID 1235:8010).
> 
> This adds Forte-specific controls (source select, HPF, phantom, phase, pad,
> gain) in the Scarlett mixer driver and hooks the device up in the USB mixer
> quirk table.
> 
> Credit: this work builds on prior reverse-engineering / device work from:
> 
> https://github.com/alastair-dm/forte-mixer
> 
> Current development work/reference:
> 
> https://github.com/jopdorp/forte-mixer
> (Links are also included via Link: tags in the commit message.)
> 
> Related project PR for gui:
> https://github.com/geoffreybennett/alsa-scarlett-gui/pull/213

Could you rather put those useful info in the patch description?

About the code changes, it looks almost fine, just some minor
nitpicks:

> @@ -172,6 +178,8 @@ struct scarlett_device_info {
>  	int input_len;
>  	int output_len;
>  
> +	int has_output_source_routing;  /* 1 if device has L/R source routing */

Better to be bool?

> +static int forte_ctl_switch_info(struct snd_kcontrol *kctl,
> +				 struct snd_ctl_elem_info *uinfo)
> +{
> +	uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
> +	uinfo->count = 1;
> +	uinfo->value.integer.min = 0;
> +	uinfo->value.integer.max = 1;
> +	return 0;
> +}

You can use snd_ctl_boolean_mono_info() instead.


thanks,

Takashi