linux-kernel - [PATCH] thermal/drivers/airoha: Fix a device node reference leak in airoha_thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260123-airoha-v1-1-ab167bb12fb7@gmail.com>
Date: Fri, 23 Jan 2026 19:55:23 +0800
From: Felix Gu <ustc.gu@...il.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, 
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
 Lukasz Luba <lukasz.luba@....com>, Christian Marangi <ansuelsmth@...il.com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Felix Gu <ustc.gu@...il.com>
Subject: [PATCH] thermal/drivers/airoha: Fix a device node reference leak
 in airoha_thermal_probe()

In airoha_thermal_probe() function, chip-scu node is acquired through
of_parse_phandle(), but it fails to release this reference if
syscon_node_to_regmap() returns an error.
Add the missing of_node_put() call to the error path to ensure the
reference count is properly decremented.

Fixes: 42de37f40e1b ("thermal/drivers: Add support for Airoha EN7581 thermal sensor")
Signed-off-by: Felix Gu <ustc.gu@...il.com>
---
 drivers/thermal/airoha_thermal.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c
index b9fd6bfc88e5..308ea846ba26 100644
--- a/drivers/thermal/airoha_thermal.c
+++ b/drivers/thermal/airoha_thermal.c
@@ -431,8 +431,10 @@ static int airoha_thermal_probe(struct platform_device *pdev)
 		return -EINVAL;

 	priv->chip_scu = syscon_node_to_regmap(chip_scu_np);
-	if (IS_ERR(priv->chip_scu))
+	if (IS_ERR(priv->chip_scu)) {
+		of_node_put(chip_scu_np);
 		return PTR_ERR(priv->chip_scu);
+	}

 	of_address_to_resource(chip_scu_np, 0, &priv->scu_adc_res);
 	of_node_put(chip_scu_np);

---
base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d
change-id: 20260123-airoha-ccd6a16a6ef6

Best regards,
-- 
Felix Gu <ustc.gu@...il.com>