linux-kernel - Re: [PATCH] selftests/mm: Have the harness run each test category separately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04fc8a05-245a-4422-9e27-704ae2d2894a@lucifer.local>
Date: Fri, 23 Jan 2026 12:09:52 +0000
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Mark Brown <broonie@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...nel.org>,
        "Liam R. Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Mike Rapoport <rppt@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, Michal Hocko <mhocko@...e.com>,
        Shuah Khan <shuah@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/mm: Have the harness run each test category
 separately

On Fri, Jan 23, 2026 at 11:21:39AM +0000, Mark Brown wrote:
> On Thu, Jan 22, 2026 at 07:13:06PM +0000, Lorenzo Stoakes wrote:
>
> > People have to edit this file to add a new test anyway so should see
> > it. Something like:
>
> > # IMPORTANT: If you add a new test CATEGORY please add a simple wrapper
> > # script so kunit knows to run it, and add it to the list below.
> > # If you do not YOUR TESTS WILL NOT RUN IN THE CI.
>
> Is the Makefile the place for that or run_vmtests.sh?  You don't need to
> edit the Makefile to add a category.

As I said, you have to edit the Make file to _add a new test_.

The point being you will necessarily see this. It'd be fairly odd to add a new
category without adding a new test.

And since you'd need to update the Makefile, putting this comment at the top of
the file immediately next to where you have to put it makes sense.

I mean by all means add it to run_vmtests.sh also.

It's all a hack, but at least this way it reduces the odds of people missing
this.

>
> > > +TEST_PROGS += ksft_vmalloc.sh
>
> > Is this something that only kunit will interpret, or will it impact the
> > build in any other way?
>
> KUnit isn't involved here?  This is just how you specify which programs
> are run by kselftest, this is a Makefile in the kselftest framework.

s/kunit/kselftest/.

I use the mm selftests locally by running sudo ./run_vmtests.sh directly. So I
don't know how TEST_GEN_PROGS interacts with anything else.