linux-kernel - Re: [PATCH 6/6] scripts: generate_rust_analyzer: move sysroot crates to sysroot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFVYSBDDF4L4.24SKCFXJ1M00A@garyguo.net>
Date: Fri, 23 Jan 2026 12:23:41 +0000
From: "Gary Guo" <gary@...yguo.net>
To: "Miguel Ojeda" <miguel.ojeda.sandonis@...il.com>, "Eliot Courtney"
 <ecourtney@...dia.com>
Cc: "Jesung Yang" <y.j3ms.n@...il.com>, "Tamir Duberstein"
 <tamird@...nel.org>, "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng"
 <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <lossin@...nel.org>, "Andreas Hindborg" <a.hindborg@...nel.org>, "Alice
 Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>, "Danilo
 Krummrich" <dakr@...nel.org>, "Nathan Chancellor" <nathan@...nel.org>,
 "Nicolas Schier" <nsc@...nel.org>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH 6/6] scripts: generate_rust_analyzer: move sysroot
 crates to sysroot_project

On Fri Jan 23, 2026 at 12:08 PM GMT, Miguel Ojeda wrote:
> On Fri, Jan 23, 2026 at 6:45 AM Eliot Courtney <ecourtney@...dia.com> wrote:
>>
>> I think it's possible to get it to work (at least better - not sure if
>> it fully fixes all issues) in RA 1.78.0 without specifying sysroot_src
>> if we add include_dirs to allow the relative #[path] references to be
>> resolved.
>
> Generally speaking, if a version of rust-analyzer is complex to
> support , then it may be best to consider avoid supporting it.
>
> It is an optional development tool and many/most use the latest
> version and/or the distro-provided one. Plus we will be moving to the
> new minimum soon, and so far we didn't support multi-version for the
> tool anyway.
>
> So, in general, if it is something trivial to support, then why not.
> Otherwise, I would recommend focusing the support on Rust 1.85 and
> later (especially the latest plus versions in popular distributions).

I would still prefer we support the RA that comes with the minimum version of
Rust. I don't care about intermediate version between minimum and popular
versions, but I pin my toolchain to 1.78.

AFAIK there's no way for rustup to use a new rust-analyzer with a old toolchain.
One can certainly download rust-analyzer from other means, but rust-analyzer
does not recommend use against old rustc, anyway.

I would avoid dropping old RA support before we actually bump MSRV.

Best,
Gary