linux-kernel - Re: [PATCH] scripts: generate_rust_analyzer.py: better pin-init macro resolvea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DFVYSCDHP5UA.2RX1AU34POA3M@gmail.com>
Date: Fri, 23 Jan 2026 21:23:44 +0900
From: "Jesung Yang" <y.j3ms.n@...il.com>
To: "SeungJong Ha" <engineer.jjhama@...il.com>, "Miguel Ojeda"
 <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: generate_rust_analyzer.py: better pin-init
 macro resolvea

Hi SeungJong,

I think I could give you some background on where things stand :)

On Fri Jan 23, 2026 at 7:02 PM KST, SeungJong Ha wrote:
[...]
>  scripts/generate_rust_analyzer.py | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index 147d0cc94068..0c6c0444917f 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -123,10 +123,18 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs, core_edit
>      append_crate(
>          "pin_init_internal",
>          srctree / "rust" / "pin-init" / "internal" / "src" / "lib.rs",
> -        [],
> +        ["std", "proc_macro"],

As Miguel pointed out, this fix has already landed on the `rust-fixes`
branch as commit "scripts: generate_rust_analyzer: Add pin_init_internal
deps" [1].

>          cfg=["kernel"],
>          is_proc_macro=True,
>      )
> +    # pin_init_internal uses #[path = "../../../macros/quote.rs"] to include quote.rs
> +    crates[-1]["source"] = {
> +        "include_dirs": [
> +            str(srctree / "rust" / "pin-init" / "internal" / "src"),
> +            str(srctree / "rust" / "macros"),
> +        ],
> +        "exclude_dirs": [],
> +    }

AFAIK, the `#[path = "../../../macros/quote.rs"]` part was removed
recently by this series [2], which is set to land in this cycle.

So I would recommend checking if the problem is still present even after
rebasing on `rust-fixes` with the new pin-init update applied (or simply
checking the `linux-next` tree as I think it has already picked up the
relevant changes).

Thanks!

[1] https://github.com/Rust-for-Linux/linux/commit/74e15ac34b098934895fd27655d098971d2b43d9
[2] https://lore.kernel.org/rust-for-linux/20260116105514.3794384-4-lossin@kernel.org/

Best regards,
Jesung